Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #126108

Merged
merged 18 commits into from
Jun 7, 2024
Merged

Rollup of 7 pull requests #126108

merged 18 commits into from
Jun 7, 2024

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    d32d1c1 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Configuration menu
    Copy the full SHA
    c74efbc View commit details
    Browse the repository at this point in the history
  2. Uplift TypeError

    compiler-errors committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    82ef3ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91274c8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    89d86ae View commit details
    Browse the repository at this point in the history
  5. Remove same-lib-two-locations-no-panic run-make test

    This test doesn't really make any sense anymore, it became broken a long time ago.
    Kobzol committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a5429d5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3a02cdb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4c2b21a View commit details
    Browse the repository at this point in the history
  8. Improve naming and path operations in crate loader

    Simplify the path operation with `join`, clarify some of the names.
    Noratrieb committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b4c439c View commit details
    Browse the repository at this point in the history
  9. Revert "Rollup merge of rust-lang#124099 - voidc:disallow-ambiguous-e…

    …xpr-attrs, r=davidtwco"
    
    This reverts commit 57dad1d, reversing
    changes made to 36316df.
    lqd committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    216424d View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    cddf291 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#125606 - diondokter:opt-size-int-fmt, r=cuv…

    …iper
    
    Size optimize int formatting
    
    Let's use the new feature flag!
    
    This uses a simpler algorithm to format integers.
    It is slower, but also smaller.
    It also saves having to import the 200 byte rodata lookup table.
    
    In a test of mine this saves ~300 bytes total of a cortex-m binary that does integer formatting.
    For a 16KB device, that's almost 2%.
    
    Note though that for opt-level 3 the text size actually grows by 116 bytes.
    Still a win in total. I'm not sure why the generated code is bigger than the more fancy algo. Maybe the smaller algo lends itself more to inlining and duplicating?
    workingjubilee authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    c6cdd45 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#125724 - compiler-errors:uplift-relate, r=lcnr

    Uplift `Relate`/`TypeRelation` into `rustc_next_trait_solver`
    
    For use in the new solver. This doesn't yet uplift `ObligationEmittingRelation`.
    
    r? lcnr
    workingjubilee authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    75aa9d1 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#126040 - Urgau:unreachable_pub-fields-less,…

    … r=petrochenkov
    
    Don't warn on fields in the `unreachable_pub` lint
    
    This PR restrict the `unreachable_pub` lint by not linting on `pub` fields of `pub(restricted)` structs and unions. This is done because that can quickly clutter the code for an uncertain value, in particular since the "real" visibility is defined by the parent (the struct it-self).
    
    This is meant to address one of the last concern of the `unreachable_pub` lint.
    
    r? ``@petrochenkov``
    workingjubilee authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    6a42df7 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#126098 - Kobzol:remove-same-lib-runmake-tes…

    …t, r=jieyouxu
    
    Remove `same-lib-two-locations-no-panic` run-make test
    
    This test doesn't really make any sense anymore, it became broken a long time ago.
    
    r? ``@jieyouxu``
    workingjubilee authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    2acb24c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#126099 - Nilstrieb:crate-loader-cleanups, r…

    …=jieyouxu
    
    Crate loader cleanups
    
    Minor cleanups I found while trying to understand how all of this works
    workingjubilee authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4c771d3 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#126101 - lqd:revert-124099, r=wesleywiser

    Revert "Disallow ambiguous attributes on expressions" on nightly
    
    As discussed in [today's t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202024-06-06/near/443079505), this reverts PR rust-lang#124099 to fix P-critical beta regressions rust-lang#125199.
    
    r? ``@wesleywiser``
    
    Opening as draft so that ``@wesleywiser`` and ``@apiraino,`` you can tell me whether you wanted:
    1. a `beta-accepted` revert of rust-lang#124099 on nightly (this PR)? That will need to be backported to beta (even though rust-lang#126093 may be the last of those)
    2. a revert of rust-lang#124099 on beta?
    3. all of the above?
    
    I also opened rust-lang#126102, another draft PR to revert rust-lang#124099 on beta, should you choose options 2 or 3.
    workingjubilee authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b1ab8d5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9436304 View commit details
    Browse the repository at this point in the history