Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #126144

Merged
merged 20 commits into from
Jun 8, 2024
Merged

Rollup of 6 pull requests #126144

merged 20 commits into from
Jun 8, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented Jun 8, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

devnexen and others added 20 commits June 4, 2024 23:33
they both support the F_GETFL fctnl flag/O_ACCMODE mask to get the file
descriptor access modes.
…/ alias. Fix alias search result showing `undefined` description.
This should help when debugging a failure in the Fuchsia build in CI.
…ion, r=Amanieu

Stabilize `error_in_core`

Closes: rust-lang#103765.

`@rustbot` label: +T-libs-api

r? libs-api
…rieb

std::unix::fs::get_mode implementation for illumos/solaris.

they both support the F_GETFL fctnl flag/O_ACCMODE mask to get the file descriptor access modes.
…ish, r=notriddle

Make html rendered by rustdoc allow searching non-English identifier / alias

Fix alias search result showing `undefined` description.

Inspired by rust-lang/mdBook#2393 .

Not sure if it's worth it adding full-text search functionality to rustdoc rendered html.
mark binding undetermined if target name exist and not obtained

- Fixes rust-lang#124490
- Fixes rust-lang#125013

Following up on rust-lang#124840, I think handling only `target_bindings` is sufficient.

r? `@petrochenkov`
Add debugging utils and comments to Fuchsia scripts

This should help when debugging a failure in the Fuchsia build in CI.

I plan to follow up with a PR to the testing section of the dev guide with more details, along with more improvements happening in the Fuchsia repo itself.

try-job: x86_64-gnu-integration
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 8, 2024
@fmease
Copy link
Member Author

fmease commented Jun 8, 2024

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jun 8, 2024

📌 Commit 733a6f1 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2024
@bors
Copy link
Contributor

bors commented Jun 8, 2024

⌛ Testing commit 733a6f1 with merge ff014f5...

@bors
Copy link
Contributor

bors commented Jun 8, 2024

☀️ Test successful - checks-actions
Approved by: fmease
Pushing ff014f5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 8, 2024
@bors bors merged commit ff014f5 into rust-lang:master Jun 8, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 8, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#125951 Stabilize error_in_core 394f49810c68728b98b2bfdd686e72c1e6b871a2 (link)
#125998 std::unix::fs::get_mode implementation for illumos/solaris. 5bd77086aa676f0ac1aaf34868f76f03515bcb06 (link)
#126057 Make html rendered by rustdoc allow searching non-English i… 40228785b3c1d45fbfc2bcdc6504e1c651c818a9 (link)
#126065 mark binding undetermined if target name exist and not obta… 6aff43639934b84b9d75076e5148f4caf55a4f69 (link)
#126105 Add debugging utils and comments to Fuchsia scripts e116844c7ef2591a7d1e6fee817948867c8952e5 (link)
#126138 Fix typo in docs for std::pin 6652252fd3120be7ccf0b3fb0e327f0d7e6877fb (link)

previous master: 8fb1930c20

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@fmease fmease deleted the rollup-i9pcdys branch June 8, 2024 05:30
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ff014f5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.3% [-2.3%, -2.3%] 1

Cycles

Results (primary 16.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
16.7% [2.6%, 33.6%] 14
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 16.7% [2.6%, 33.6%] 14

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 319.63 MiB -> 319.64 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants