Skip to content

reachable computation: clarify comments around consts #126259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

reachable computation: clarify comments around consts #126259

merged 1 commit into from
Jun 11, 2024

Conversation

RalfJung
Copy link
Member

Follow-up to #122505

@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2024
@RalfJung RalfJung mentioned this pull request Jun 11, 2024
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Jun 11, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 11, 2024

📌 Commit be4cd53 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2024
@oli-obk oli-obk assigned oli-obk and unassigned compiler-errors Jun 11, 2024
@jieyouxu jieyouxu mentioned this pull request Jun 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2024
@bors
Auto merge of rust-lang#126262 - jieyouxu:rollup-g29lo3c, r=jieyouxu
6a207f4 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#125913 (Spruce up the diagnostics of some early lints)
 - rust-lang#126234 (Delegation: fix ICE on late diagnostics)
 - rust-lang#126253 (Simplify assert matchers in `run-make-support`)
 - rust-lang#126257 (Rename `needs-matching-clang` to `needs-force-clang-based-tests`)
 - rust-lang#126259 (reachable computation: clarify comments around consts)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 36c884c into rust-lang:master Jun 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2024
@rust-timer
Unrolled build for rust-lang#126259
1a95634 
Rollup merge of rust-lang#126259 - RalfJung:reachable-const, r=oli-obk

reachable computation: clarify comments around consts

Follow-up to rust-lang#122505
@rustbot rustbot added this to the 1.81.0 milestone Jun 11, 2024
@RalfJung RalfJung deleted the reachable-const branch June 11, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rustbot @oli-obk @bors @compiler-errors