[beta] Ensure self-contained linker is only enabled on dev/nightly #126278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
[beta] Check self-contained linker status It seems the self-contained linker is enabled on beta. Let's fix that. r? ghost
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
[beta] Check self-contained linker status It seems the self-contained linker is enabled on beta. Let's fix that. r? ghost
|
The two debugging try builds show that
|
lqd
changed the title
|
This last try build should make a beta with @bors try There's some weird formatting issue in libstd on the |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
[beta] Ensure self-contained linker is only enabled on dev/nightly
It seems the self-contained linker is enabled on beta. Let's fix that.
```console
$ cargo clean && cargo +beta build && readelf -p .comment target/debug/helloworld
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.15s
String dump of section '.comment':
[ 0] Linker: LLD 18.1.7
[ 14] GCC: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
[ 3f] rustc version 1.80.0-beta.1 (75ac3b6 2024-06-10)
```
I will open a PR to fix it on master as well, right after I test CI's behavior on beta.
|
☀️ Try build successful - checks-actions |
$ cargo clean -q && cargo +b001caeb5f27dc7d97ec2e0b24a4e044e4d90ae6 build -q && readelf -p .comment target/debug/helloworld
String dump of section '.comment':
[ 0] GCC: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
[ 2b] rustc version 1.80.0-beta.2 (b001caeb5 2024-06-11)(if such a try build on the |
|
@bors r+ rollup=never Format doesn't get enforced or run on non-master to avoid complicating backports with reformatting (or distro builds). |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 12, 2024
…ker, r=Mark-Simulacrum Ensure self-contained linker is only enabled on dev/nightly This is a version of rust-lang#126278 for the master branch. It should be no-op _here_, compared to beta. I'll r? `@Mark-Simulacrum` like the other one.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 12, 2024
Rollup merge of rust-lang#126282 - lqd:contain-the-self-contained-linker, r=Mark-Simulacrum Ensure self-contained linker is only enabled on dev/nightly This is a version of rust-lang#126278 for the master branch. It should be no-op _here_, compared to beta. I'll r? `@Mark-Simulacrum` like the other one.
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the self-contained linker is enabled on beta. Let's fix that.
I will open a PR to fix it on master as well, right after I test CI's behavior on beta.