Cleaned up trans_fail(), per eddyb request. #12636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let sess = bcx.sess(); | ||
| let loc = sess.parse_sess.cm.lookup_char_pos(sp.lo); | ||
| let V_filename = C_cstr(bcx.ccx(), | ||
| token::intern_and_get_ident(loc.file.name)); |
There was a problem hiding this comment.
This can probably be one line (the column limit is 100 chars).
(At least, token should line up with bcx.)
(PS. sorry for sending you down a rabbit hole. :) )
|
This looks nicer with your indentation suggestion, @huonw. I can't reproduce the Travis CI failure locally though. |
bors
added a commit
that referenced
this pull request
Mar 2, 2014
Cleaned up trans_fail(), per eddyb request. Reviewed-by: huonw
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
complete raw identifier with "r#" prefix Fix rust-lang#12148 Escape Names and Paths used in `insert_text`/`insert_snippet` while rendering the completion items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some unused code and simplifies the remaining code.