Point out failing never obligation for DEPENDENCY_ON_UNIT_NEVER_TYPE_FALLBACK
#126367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
compiler-errors
commented
Jun 13, 2024
| && let never_errors = remaining_errors_if_fallback_to(self.tcx.types.never) | ||
| && !never_errors.is_empty() | ||
| && let mut never_errors = remaining_errors_if_fallback_to(self.tcx.types.never) | ||
| && let [ref mut never_error, ..] = never_errors.as_mut_slice() |
There was a problem hiding this comment.
Do you think we should lint individually on each failing obligation?
Or maybe I should make it a subdiagnostic so we can have multiple of them?
If we print out >1, I should probably do some deduplication like we do for real fulfillment errors 🤔
There was a problem hiding this comment.
I think ideally we should print out all the errors, but maybe it will be too noisy, idk. This PR as is seems like a good first step/clear improvement.
compiler-errors
commented
Jun 13, 2024
| && let never_errors = remaining_errors_if_fallback_to(self.tcx.types.never) | ||
| && !never_errors.is_empty() | ||
| && let mut never_errors = remaining_errors_if_fallback_to(self.tcx.types.never) | ||
| && let [ref mut never_error, ..] = never_errors.as_mut_slice() |
There was a problem hiding this comment.
I think ideally we should print out all the errors, but maybe it will be too noisy, idk. This PR as is seems like a good first step/clear improvement.
| @@ -45,6 +45,7 @@ hir_typeck_convert_using_method = try using `{$sugg}` to convert `{$found}` to ` | |||
| hir_typeck_ctor_is_private = tuple struct constructor `{$def}` is private | |||
|
|
|||
| hir_typeck_dependency_on_unit_never_type_fallback = this function depends on never type fallback being `()` | |||
| .note = in edition 2024, the requirement `{$obligation}` will fail | |||
There was a problem hiding this comment.
maybe we can mention somehow that we plan to break this on all editions eventually?
There was a problem hiding this comment.
do you have an opinion on the wording?
Suggested change
| .note = in edition 2024, the requirement `{$obligation}` will fail | |
| .note = in edition 2024, the requirement `{$obligation}` will fail, and eventually this will fail everywhere |
seems awkward, and I have no idea what a better wording could be 🤔
|
☔ The latest upstream changes (presumably #125289) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
point-out-failing-never-obligation
branch
from
05ecac2
to
fdd90db
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
8 tasks
WaffleLapkin
approved these changes
Jun 15, 2024
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#126354 (Use `Variance` glob imported variants everywhere) - rust-lang#126367 (Point out failing never obligation for `DEPENDENCY_ON_UNIT_NEVER_TYPE_FALLBACK`) - rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid) - rust-lang#126471 (Use a consistent way to filter out bounds instead of splitting it into three places) - rust-lang#126472 (build `libcxx-version` only when it doesn't exist) - rust-lang#126497 (delegation: Fix hygiene for `self`) - rust-lang#126501 (make bors ignore comments in PR template) - rust-lang#126509 (std: suggest OnceLock over Once) - rust-lang#126512 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2024
Rollup merge of rust-lang#126367 - compiler-errors:point-out-failing-never-obligation, r=WaffleLapkin Point out failing never obligation for `DEPENDENCY_ON_UNIT_NEVER_TYPE_FALLBACK` Based on top of rust-lang#125289, so just need to look at the last commit. r? `@WaffleLapkin`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #125289, so just need to look at the last commit.
r? @WaffleLapkin