interpret: update doc comment for find_closest_untracked_caller_location #126379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
RalfJung
force-pushed
the
find_closest_untracked_caller_location
branch
from
14af33c
to
d87ec03
Compare
RalfJung
commented
Jun 13, 2024
| @@ -250,7 +250,7 @@ impl<'tcx, Prov: Provenance> Frame<'tcx, Prov> { | |||
| impl<'tcx, Prov: Provenance, Extra> Frame<'tcx, Prov, Extra> { | |||
| /// Get the current location within the Frame. | |||
| /// | |||
| /// If this is `Left`, we are not currently executing any particular statement in | |||
| /// If this is `Right`, we are not currently executing any particular statement in | |||
There was a problem hiding this comment.
I also just realized this comment is wrong, and fixed it.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#126347 (Simplify `try_*`'s signature on `Iterator`) - rust-lang#126348 (Improve error message if dependency installation in tidy fails) - rust-lang#126366 (Add a new trait to retrieve StableMir definition Ty) - rust-lang#126370 (compiletest: Stricter parsing of `//@ normalize-*` headers) - rust-lang#126379 (interpret: update doc comment for find_closest_untracked_caller_location) - rust-lang#126384 (add tracking issue for is_none_or) Failed merges: - rust-lang#126388 (const-eval: make lint scope computation consistent) r? `@ghost` `@rustbot` modify labels: rollup
|
Thanks! |
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2024
Rollup merge of rust-lang#126379 - RalfJung:find_closest_untracked_caller_location, r=oli-obk interpret: update doc comment for find_closest_untracked_caller_location Also add a doc comment to cur_span. r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a doc comment to cur_span.
r? @compiler-errors