Actually report normalization-based type errors correctly for alias-relate obligations in new solver #126403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #126491) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
better-type-errors
branch
from
8a99182 to
83db527
Compare
|
☔ The latest upstream changes (presumably #127076) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
better-type-errors
branch
from
83db527 to
5772c90
Compare
This comment has been minimized.
This comment has been minimized.
|
r=me after CI |
…elate obligations in new solver
compiler-errors
force-pushed
the
better-type-errors
branch
from
5772c90 to
ecdaff2
Compare
|
@bors r=lcnr rollup |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some special casing to report type mismatch errors that come from projection predicates, but we don't do that for alias-relate obligations. This PR implements that. There's a bit of code duplication, but 🤷
Best reviewed without whitespace.
r? lcnr