Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const validation: fix ICE on dangling ZST reference #126426

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

RalfJung
Copy link
Member

Fixes #126393
I'm not super happy with this fix but I can't think of a better one.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 13, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 13, 2024

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member Author

Just a case of #126430.

@RalfJung RalfJung closed this Jun 14, 2024
@RalfJung RalfJung reopened this Jun 14, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Jun 14, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 14, 2024

📌 Commit a690710 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 14, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123769 (Improve escaping of byte, byte str, and c str proc-macro literals)
 - rust-lang#126054 (`E0229`: Suggest Moving Type Constraints to Type Parameter Declaration)
 - rust-lang#126135 (add HermitOS support for vectored read/write operations)
 - rust-lang#126266 (Unify guarantees about the default allocator)
 - rust-lang#126285 (`UniqueRc`: support allocators and `T: ?Sized`.)
 - rust-lang#126399 (extend the check for LLVM build)
 - rust-lang#126426 (const validation: fix ICE on dangling ZST reference)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit aebd794 into rust-lang:master Jun 14, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 14, 2024
Rollup merge of rust-lang#126426 - RalfJung:dangling-zst-ice, r=oli-obk

const validation: fix ICE on dangling ZST reference

Fixes rust-lang#126393
I'm not super happy with this fix but I can't think of a better one.

r? `@oli-obk`
@rustbot rustbot added this to the 1.81.0 milestone Jun 14, 2024
@RalfJung RalfJung deleted the dangling-zst-ice branch June 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: could not find allocation for alloc3
5 participants