Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against calling libc::exit multiple times on Linux. #126606

Merged
merged 12 commits into from
Jul 13, 2024
Merged

Guard against calling libc::exit multiple times on Linux. #126606

merged 12 commits into from
Jul 13, 2024

Commits on Jun 21, 2024

  1. On target_os = "linux", ensure that only one Rust thread calls `lib… 

    …c::exit` or returns from `main`.
    @zachs18
    zachs18 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e71d06b View commit details
    Browse the repository at this point in the history

  2. fix rustdoc URL

    @zachs18
    zachs18 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    bff3531 View commit details
    Browse the repository at this point in the history

  3. Don't perform mitigation for thread-unsafe libc::exit under Miri. 

    1. Miri's exit is thread-safe
2. Miri doesn't (yet) support `libc::gettid`, used in the implementation of the mitigation on Linux.
    @zachs18
    zachs18 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c36fdeb View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Use libc::pause instead of std::thread::park in wait-for-exit loop

    @zachs18
    zachs18 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    5e83faf View commit details
    Browse the repository at this point in the history

  2. Use pthread_t instead of numeric thread id

    @zachs18
    zachs18 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    897fb6c View commit details
    Browse the repository at this point in the history

  3. Remove Miri special-case

    @zachs18
    zachs18 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b512608 View commit details
    Browse the repository at this point in the history

  4. Move unique_thread_exit call to lang_start_internal so it is not in a… 

    … generic function, and wrap it in `catch_unwind`
    @zachs18
    zachs18 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b4149c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Update library/std/src/sys/pal/common/exit_guard.rs 

    Co-authored-by: Ralf Jung <post@ralfj.de>
    @zachs18 @RalfJung
    zachs18 and RalfJung authored Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9de76e3 View commit details
    Browse the repository at this point in the history

  2. Move exit guard from sys::common::exit_guard to sys::exit_guard.

    @zachs18
    zachs18 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a609370 View commit details
    Browse the repository at this point in the history

  3. Attempt to fix CI

    @zachs18
    zachs18 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5db1655 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Move/change declaration of mod exit_guard;

    @zachs18
    zachs18 authored Jul 7, 2024
    Configuration menu
    Copy the full SHA
    9801076 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Attempt to fix CI

    @zachs18
    zachs18 authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8bcbab5 View commit details
    Browse the repository at this point in the history