Rework doc-test attribute documentation example #126681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Jun 19, 2024
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 19, 2024
…eGomez Rework doc-test attribute documentation example This PR change the doc-test attribute documentation example to prefer a more neutral example `deny(dead_code)`, instead of `deny(warnings)`, which is less susceptible to breakage across Rust version. r? ``@GuillaumeGomez``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2024
…fee1-dead Rollup of 5 pull requests Successful merges: - rust-lang#126668 (Remove now NOP attrs `#[rustc_dump{,_env}_program_clauses]`) - rust-lang#126674 (Allow tracing through item_bounds query invocations on opaques) - rust-lang#126675 (Change a `DefineOpaqueTypes::No` to `Yes` in diagnostics code) - rust-lang#126681 (Rework doc-test attribute documentation example) - rust-lang#126684 (Migrate `run-make/glibc-staticlib-args` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2024
Rollup merge of rust-lang#126681 - Urgau:rustdoc-deny-doc, r=GuillaumeGomez Rework doc-test attribute documentation example This PR change the doc-test attribute documentation example to prefer a more neutral example `deny(dead_code)`, instead of `deny(warnings)`, which is less susceptible to breakage across Rust version. r? ```@GuillaumeGomez```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the doc-test attribute documentation example to prefer a more neutral example
deny(dead_code), instead ofdeny(warnings), which is less susceptible to breakage across Rust version.r? @GuillaumeGomez