Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Overhaul validation of the #[coverage(..)] attribute #126682

Merged
merged 4 commits into from
Jun 24, 2024
Merged

coverage: Overhaul validation of the #[coverage(..)] attribute #126682

merged 4 commits into from
Jun 24, 2024

Commits on Jun 24, 2024

  1. coverage: Forbid multiple #[coverage(..)] attributes 

    It might make sense to allow this in the future, if we add values that aren't
mutually exclusive, but for now having multiple coverage attributes on one item
is useless.
    @Zalathar
    Zalathar committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b5dfeba View commit details
    Browse the repository at this point in the history

  2. coverage: Tighten validation of #[coverage(off)] and #[coverage(on)]

    @Zalathar
    Zalathar committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a000fa8 View commit details
    Browse the repository at this point in the history

  3. coverage: Always error on #[coverage(..)] in unexpected places 

    This upgrades some warnings to errors, and also catches cases where the
attribute was silently ignored.
    @Zalathar
    Zalathar committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b7c057c View commit details
    Browse the repository at this point in the history

  4. coverage: Bless coverage attribute tests

    @Zalathar
    Zalathar committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    1852141 View commit details
    Browse the repository at this point in the history