Refactor Miri float casting tests #126727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to remove the magic from a lot of the numbers tested, which should make things easier when it is time to add `f16` and `f128`. A nice side effect is that these tests now cover all int <-> float conversions with the same amount of tests.
rustbot
added
the
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri |
|
Thanks! Is it possible to make this a PR in the Miri repo? We have more test coverage there (such as a big-endian target). |
|
Sure, gimme a few Minütchen |
|
It is up at rust-lang/miri#3688 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to remove the magic from a lot of the numbers tested, which should make things easier when it is time to add
f16andf128. A nice side effect is that these tests now cover all int <-> float conversions with the same amount of tests.I opted to not add
f16andf128in this PR since we still dont have the constants needed for many of these tests (they will come in #126608, but that is blocked on #126636 and possibly #125016).r? @RalfJung