Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect attrs in const block expr #126735

Merged
merged 1 commit into from
Jun 20, 2024
Merged

collect attrs in const block expr #126735

merged 1 commit into from
Jun 20, 2024

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jun 20, 2024

Fixes #126516
Fixes #126647

It was forgotten to collect these attributes in the const block expression.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 20, 2024
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 20, 2024

📌 Commit 1e42bb6 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126095 (Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake`)
 - rust-lang#126629 (Migrate `run-make/compressed-debuginfo` to `rmake.rs`)
 - rust-lang#126644 (Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake)
 - rust-lang#126735 (collect attrs in const block expr)
 - rust-lang#126737 (Remove `feature(const_closures)` from libcore)
 - rust-lang#126740 (add `needs-unwind` to UI test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2fa148e into rust-lang:master Jun 20, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2024
Rollup merge of rust-lang#126735 - bvanjoi:fix-126647, r=petrochenkov

collect attrs in const block expr

Fixes rust-lang#126516
Fixes rust-lang#126647

It was forgotten to collect these attributes in the const block expression.

r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: expanded a dummy bang macro ICE: incr: no entry found for key
4 participants