Fix a few libnative bugs #12705
Closed
Fix a few libnative bugs #12705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is not threadsafe, and is deprecated in favor of the threadsafe readdir_r variant. Closes rust-lang#12692
Using nanosleep() allows us to gracefully recover from EINTR because on error it fills in the second parameter with the remaining time to sleep. Closes rust-lang#12689
When the timer_helper thread exited, it would attempt to re-acquire the global task count mutex, but the mutex had previously been deallocated, leading to undefined behavior of the mutex, and in some cases deadlock. Another mutex is used to coordinate shutting down the timer helper thread. Closes rust-lang#12699
|
I have one more bug fix one the way which will nicely roll into this PR |
|
Bugfix added |
When using tasks in Rust, the expectation is that the runtime does not exit before all tasks have exited. This is enforced in libgreen through the `SchedPool` type, and it is enforced in libnative through a `bookkeeping` module and a global count/mutex pair. Unfortunately, this means that a process which originates with libgreen will not wait for spawned native tasks. In order to fix this problem, the bookkeeping module was moved from libnative to libstd so the runtime itself can wait for native tasks to exit. Green tasks do not manage themselves through this bookkeeping module, but native tasks will continue to manage themselves through this module. Closes rust-lang#12684
bors
added a commit
that referenced
this pull request
Mar 6, 2014
Details are in the commit messages, but this closes a few issues seen with `libnative` recently.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
This change fixes rust-lang#12705. In `FunctionBody::analyze`, we need to search any `ClosureExpr`s we encounter for any `NameRef`s, to ensure they aren't missed.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…r=DorianListens fix: Extract Function misses locals used in closures This change fixes rust-lang#12705. In `FunctionBody::analyze`, we need to search any `ClosureExpr`s we encounter for any `NameRef`s, to ensure they aren't missed.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 2, 2024
chore: fix some typos in comments *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in the commit messages, but this closes a few issues seen with
libnativerecently.