Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the way bootstrap handles rustlib components #127188

Merged
merged 2 commits into from
Jul 1, 2024
Merged

improve the way bootstrap handles rustlib components #127188

merged 2 commits into from
Jul 1, 2024

Commits on Jul 1, 2024

  1. improve the way bootstrap handles rustlib components 

    When CI rustc is enabled, bootstrap tries to symlink the rust source (project root)
into target sysroot right before copying it from the CI rustc's sysroot. This becomes
a problem in CI builders (which we currently don't see because they don't use CI rustc)
because the copying part will fail as they run on read-only mode.

This change fixes the problem by copying `rustc-src` from the CI rustc sysroot and only symlinking
`rustc-src` from the rust source when download-rustc is not enabled.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
    @onur-ozkan
    onur-ozkan committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    fe6f3fa View commit details
    Browse the repository at this point in the history

  2. fail on component linking errors 

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    @onur-ozkan
    onur-ozkan committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    97415ce View commit details
    Browse the repository at this point in the history