Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback on unix filesystem's remove_dir_impl for target vxworks #127194

Closed
wants to merge 1 commit into from

Conversation

biabbas
Copy link
Contributor

@biabbas biabbas commented Jul 1, 2024

Hi all,
I'm skipping the unix filesystem remove_dir_impl for target vxworks. As seen in the error #127084, remove_dir_impl need libc imports fdopendir, openat, unlinkat. These need to be introduced in libc and tested for vxworks. Thus we are temporarily falling back on remove_dir_impl as our priority is to get a successful build on vxworks.

Thank you.

@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 1, 2024
@biabbas biabbas closed this Jul 3, 2024
@biabbas
Copy link
Contributor Author

biabbas commented Jul 3, 2024

This pr was merged into PR #127195

@biabbas biabbas deleted the remove_dir_impl branch July 3, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants