Relax CallOnceFuture/CallRefFuture bound from Future to IntoFuture
#127225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
T-libs
compiler-errors
commented
Jul 1, 2024
| @@ -130,7 +132,8 @@ pub trait IntoFuture { | |||
| /// # } | |||
| /// ``` | |||
| #[stable(feature = "into_future", since = "1.64.0")] | |||
| #[lang = "into_future"] | |||
| #[cfg_attr(not(bootstrap), lang = "into_future_into_future")] | |||
There was a problem hiding this comment.
Renamed the existing lang item to into_future_into_future, and reused that name for the trait name for consistency!
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
async-fn-into-future
branch
from
47176bf
to
c35e984
Compare
compiler-errors
added
S-blocked
|
only opened this for demo, will reopen if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the change suggested in rust-lang/rfcs#3668 (comment). Blocked on some relevant team deciding whether to use
IntoFutureorFutureforAsyncFnOncebounds.This also adds
IntoFutureandIntoFuture::Outputas lang items, so they can be referenced in those trait bounds.Notable: the concrete future returned by calling a concrete async closure still implements
FutureandIntoFuture. This just makes the trait definition more generic, so the caller can pass more kinds of closures in.r? oli-obk
Tracking:
# #62290