Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update config file path in platform-support/wasm32-wasip1-threads.md #127236

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

iawia002
Copy link
Contributor

@iawia002 iawia002 commented Jul 2, 2024

The config content described in the Building the target section should be the configuration used for building Rust itself:

rust/config.example.toml

Lines 845 to 848 in 7d97c59

# The root location of the `wasm32-wasip1` sysroot. Only used for WASI
# related targets. Make sure to create a `[target.wasm32-wasip1]`
# section and move this field there (or equivalent for the target being built).
#wasi-root = <none> (path)

I believe this is different from Cargo's configuration. There seems to be some misunderstanding in the discussion here: #112922 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

@GuillaumeGomez
Copy link
Member

r? Nilstrieb

@rustbot rustbot assigned Noratrieb and unassigned GuillaumeGomez Jul 2, 2024
@Noratrieb
Copy link
Member

good catch! see #126875
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 7, 2024

📌 Commit ba1ebc2 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 7, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#127179 (Print `TypeId` as hex for debugging)
 - rust-lang#127189 (LinkedList's Cursor: method to get a ref to the cursor's list)
 - rust-lang#127236 (doc: update config file path in platform-support/wasm32-wasip1-threads.md)
 - rust-lang#127297 (Improve std::Path's Hash quality by avoiding prefix collisions)
 - rust-lang#127308 (Attribute cleanups)
 - rust-lang#127354 (Describe Sized requirements for mem::offset_of)
 - rust-lang#127409 (Emit a wrap expr span_bug only if context is not tainted)
 - rust-lang#127447 (once_lock: make test not take as long in Miri)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d84d221 into rust-lang:master Jul 7, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 7, 2024
Rollup merge of rust-lang#127236 - iawia002:wasip1-threads-doc, r=Nilstrieb

doc: update config file path in platform-support/wasm32-wasip1-threads.md

The config content described in the `Building the target` section should be the configuration used for building Rust itself:

https://github.com/rust-lang/rust/blob/7d97c59438e933e86f557ed999da3b8dfc6855a7/config.example.toml#L845-L848

I believe this is different from Cargo's configuration. There seems to be some misunderstanding in the discussion here: rust-lang#112922 (comment).
@iawia002 iawia002 deleted the wasip1-threads-doc branch July 8, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants