Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that allocations output by GVN are sufficiently aligned. #127399

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Verify that allocations output by GVN are sufficiently aligned. #127399

merged 3 commits into from
Jul 8, 2024

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jul 5, 2024

Fixes #127396

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@cjgillot @compiler-errors
Update compiler/rustc_mir_transform/src/gvn.rs
12edc8d 
Co-authored-by: Michael Goulet <michael@errs.io>
@oli-obk
Copy link
Contributor

oli-obk commented Jul 8, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 8, 2024

📌 Commit 12edc8d has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2024
@bors
Auto merge of rust-lang#127486 - matthiaskrgr:rollup-lvv018b, r=matth…
a06e9c8 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#120248 (Make casts of pointers to trait objects stricter)
 - rust-lang#127355 (Mark format! with must_use hint)
 - rust-lang#127399 (Verify that allocations output by GVN are sufficiently aligned.)
 - rust-lang#127460 (clarify `sys::unix::fd::FileDesc::drop` comment)
 - rust-lang#127467 (bootstrap: once_cell::sync::Lazy -> std::sync::LazyLock)

Failed merges:

 - rust-lang#127357 (Remove `StructuredDiag`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3e8e8df into rust-lang:master Jul 8, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 8, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2024
@rust-timer
Unrolled build for rust-lang#127399
5b9176f 
Rollup merge of rust-lang#127399 - cjgillot:issue-127396, r=oli-obk

Verify that allocations output by GVN are sufficiently aligned.

Fixes rust-lang#127396

r? `@oli-obk`
@Kobzol
Copy link
Contributor

Kobzol commented Jul 9, 2024

@rust-timer build 5b9176f

@rust-timer

This comment has been minimized.

Sign in to view
@cjgillot cjgillot deleted the issue-127396 branch July 9, 2024 22:11
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5b9176f): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -7.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -7.2% [-7.2%, -7.2%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.3%, 2.8%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 701.941s -> 701.705s (-0.03%)
Artifact size: 328.61 MiB -> 328.60 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.

Compiler error in release mode when transmuting Option<u32>
7 participants
@cjgillot @rustbot @oli-obk @bors @Kobzol @rust-timer @compiler-errors