Skip to content

Conversation

Noratrieb
Copy link
Member

@Noratrieb Noratrieb commented Jul 7, 2024

fixes pathological tidy performance described in #127453 by reverting #127428

i think anyone can approve this ASAP, it makes working on this repo significantly worse.

Noratrieb added 2 commits July 7, 2024 14:22
This reverts commit 8d85043.

The regexes are important for performance.
@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 7, 2024
@Noratrieb
Copy link
Member Author

@bors p=1

@jieyouxu
Copy link
Member

jieyouxu commented Jul 7, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 7, 2024

📌 Commit 1cfc89a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2024
@Noratrieb
Copy link
Member Author

@bors p=10 let's jump ahead of the rollup

@Noratrieb
Copy link
Member Author

@bors retry hello, bump

@bors
Copy link
Collaborator

bors commented Jul 7, 2024

⌛ Testing commit 1cfc89a with merge 959a2eb...

@bors
Copy link
Collaborator

bors commented Jul 7, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 959a2eb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2024
@bors bors merged commit 959a2eb into rust-lang:master Jul 7, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jul 7, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (959a2eb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.9%, secondary -2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.9% [0.7%, 2.8%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) 0.9% [-2.2%, 2.8%] 4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 699.903s -> 699.476s (-0.06%)
Artifact size: 328.38 MiB -> 328.39 MiB (0.01%)

@Noratrieb Noratrieb deleted the blazing-tidy branch July 7, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants