Make visit_clobber's impl safe

[oli-obk]

This was originally introduced in #58061 but I didn't see any perf discussion about it, so let's see what perf says.

r? @nnethercote

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 3562ec7 with merge caf9e2f...

[bors]

☀️ Try build successful - checks-actions
Build commit: caf9e2f (caf9e2f04a628507c5aece14d75c64f69f806650)

[rust-timer]

Finished benchmarking commit (caf9e2f): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.3%	[3.3%, 3.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 703.707s -> 705.601s (0.27%)
Artifact size: 328.71 MiB -> 328.74 MiB (0.01%)

[oli-obk]

sweet

[nnethercote]

Huh, interesting.

@bors r+

[bors]

📌 Commit 3562ec7 has been approved by nnethercote

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3562ec7 with merge 3ad5f45...

[bors]

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing 3ad5f45 to master...

[rust-timer]

Finished benchmarking commit (3ad5f45): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-1.1%, -0.2%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 704.958s -> 703.792s (-0.17%)
Artifact size: 328.69 MiB -> 328.53 MiB (-0.05%)