rustc: Fix x86 ffi for struct arguments #12762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is two distinct bug fixes (by-val and empty structs), it would be nice to have two separate commits for each. |
|
Separated two fixes. Also added |
This fixes struct passing abi on x86 ffi: Structs are now passed indirectly with byval attribute (as clang does).
|
Removed unrelated change (discussion here) and it passed |
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Dec 15, 2024
This updates the documentation after rust-lang#13694. It is not based on that PR chain and can be merged independently, but should be merged after that PR. This is partly pulled from rust-lang#12762, but removing the Josh parts. This includes instructions on how to publish `clippy_utils`. Closes rust-lang/rust-clippy#13556 (yes, this is the final PR 🙂) r? @blyxyas changelog: `clippy_utils` is now published to crates.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes struct passing abi on x86 ffi: Structs are now passed
indirectly with byval attribute (as clang does).
Empty structs are also explicitly ignored rather than directly passed.
Fixes #5744
Fixes #11198
Fixes #11343