-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unignore cg_gcc fmt #127652
Unignore cg_gcc fmt #127652
Conversation
This comment has been minimized.
This comment has been minimized.
b203aa9
to
12c1f5c
Compare
Some changes occurred in compiler/rustc_codegen_gcc |
This comment has been minimized.
This comment has been minimized.
Is When running |
We are using a different config than the one in Lines 1 to 4 in b286722
maybe that's the difference. Also Lines 19 to 20 in b286722
It also quite possible that |
We're using nightly fmt as well and the config looks compatible with what we have: use_small_heuristics = "Max" No clue what's going on... |
Did you tried adding |
I didn't. But some new changes like this one: pub enum E2<X> {
V1 { f: bool },
- /*_00*/ _01(X), _02(X), _03(X), _04(X), _05(X), _06(X), _07(X),
- _08(X), _09(X), _0A(X), _0B(X), _0C(X), _0D(X), _0E(X), _0F(X),
- _10(X), _11(X), _12(X), _13(X), _14(X), _15(X), _16(X), _17(X),
- _18(X), _19(X), _1A(X), _1B(X), _1C(X), _1D(X), _1E(X), _1F(X),
- _20(X), _21(X), _22(X), _23(X), _24(X), _25(X), _26(X), _27(X),
- _28(X), _29(X), _2A(X), _2B(X), _2C(X), _2D(X), _2E(X), _2F(X),
- _30(X), _31(X), _32(X), _33(X), _34(X), _35(X), _36(X), _37(X),
- _38(X), _39(X), _3A(X), _3B(X), _3C(X), _3D(X), _3E(X), _3F(X),
- _40(X), _41(X), _42(X), _43(X), _44(X), _45(X), _46(X), _47(X),
- _48(X), _49(X), _4A(X), _4B(X), _4C(X), _4D(X), _4E(X), _4F(X),
- _50(X), _51(X), _52(X), _53(X), _54(X), _55(X), _56(X), _57(X),
- _58(X), _59(X), _5A(X), _5B(X), _5C(X), _5D(X), _5E(X), _5F(X),
- _60(X), _61(X), _62(X), _63(X), _64(X), _65(X), _66(X), _67(X),
- _68(X), _69(X), _6A(X), _6B(X), _6C(X), _6D(X), _6E(X), _6F(X),
- _70(X), _71(X), _72(X), _73(X), _74(X), _75(X), _76(X), _77(X),
- _78(X), _79(X), _7A(X), _7B(X), _7C(X), _7D(X), _7E(X), _7F(X),
- _80(X), _81(X), _82(X), _83(X), _84(X), _85(X), _86(X), _87(X),
- _88(X), _89(X), _8A(X), _8B(X), _8C(X), _8D(X), _8E(X), _8F(X),
- _90(X), _91(X), _92(X), _93(X), _94(X), _95(X), _96(X), _97(X),
- _98(X), _99(X), _9A(X), _9B(X), _9C(X), _9D(X), _9E(X), _9F(X),
- _A0(X), _A1(X), _A2(X), _A3(X), _A4(X), _A5(X), _A6(X), _A7(X),
- _A8(X), _A9(X), _AA(X), _AB(X), _AC(X), _AD(X), _AE(X), _AF(X),
- _B0(X), _B1(X), _B2(X), _B3(X), _B4(X), _B5(X), _B6(X), _B7(X),
- _B8(X), _B9(X), _BA(X), _BB(X), _BC(X), _BD(X), _BE(X), _BF(X),
- _C0(X), _C1(X), _C2(X), _C3(X), _C4(X), _C5(X), _C6(X), _C7(X),
- _C8(X), _C9(X), _CA(X), _CB(X), _CC(X), _CD(X), _CE(X), _CF(X),
- _D0(X), _D1(X), _D2(X), _D3(X), _D4(X), _D5(X), _D6(X), _D7(X),
- _D8(X), _D9(X), _DA(X), _DB(X), _DC(X), _DD(X), _DE(X), _DF(X),
- _E0(X), _E1(X), _E2(X), _E3(X), _E4(X), _E5(X), _E6(X), _E7(X),
- _E8(X), _E9(X), _EA(X), _EB(X), _EC(X), _ED(X), _EE(X), _EF(X),
- _F0(X), _F1(X), _F2(X), _F3(X), _F4(X), _F5(X), _F6(X), _F7(X),
- _F8(X), _F9(X), _FA(X), _FB(X), _FC(X), _FD(X), _FE(X), _FF(X),
+ /*_00*/ _01(X),
+ _02(X),
+ _03(X),
+ _04(X),
+ _05(X),
+ _06(X),
+ _07(X),
+ _08(X),
+ _09(X),
+ _0A(X),
+ _0B(X),
+ _0C(X),
+ _0D(X),
+ _0E(X),
+ _0F(X),
+ _10(X),
+ _11(X), Are a big no. I'll try to see if it can be kept somehow. |
You can put |
12c1f5c
to
213782d
Compare
cc @antoyo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes look good to me.
@bors r+ |
Unignore cg_gcc fmt `rustc_codegen_gcc` uses `rustfmt` now so it can be unignored. r? `@Urgau`
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127542 ([`macro_metavar_expr_concat`] Add support for literals) - rust-lang#127652 (Unignore cg_gcc fmt) - rust-lang#127664 (Fix precise capturing suggestion for hidden regions when we have APITs) - rust-lang#127806 (Some parser improvements) - rust-lang#127828 (Commonize `uname -m` results for `aarch64` in docker runner) - rust-lang#127845 (unix: break `stack_overflow::install_main_guard` into smaller fn) - rust-lang#127854 (Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent`) - rust-lang#127861 (Document the column numbers for the dbg! macro) - rust-lang#127875 (style-guide: Clarify version-sorting) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 9 pull requests Successful merges: - rust-lang#127542 ([`macro_metavar_expr_concat`] Add support for literals) - rust-lang#127652 (Unignore cg_gcc fmt) - rust-lang#127664 (Fix precise capturing suggestion for hidden regions when we have APITs) - rust-lang#127806 (Some parser improvements) - rust-lang#127828 (Commonize `uname -m` results for `aarch64` in docker runner) - rust-lang#127845 (unix: break `stack_overflow::install_main_guard` into smaller fn) - rust-lang#127859 (ptr::metadata: avoid references to extern types) - rust-lang#127861 (Document the column numbers for the dbg! macro) - rust-lang#127875 (style-guide: Clarify version-sorting) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#127652 - GuillaumeGomez:cg-gcc-fmt, r=Urgau Unignore cg_gcc fmt `rustc_codegen_gcc` uses `rustfmt` now so it can be unignored. r? ``@Urgau``
rustc_codegen_gcc
usesrustfmt
now so it can be unignored.r? @Urgau