Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue of invalid suggestion for a reference of iterator #127669

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix the issue of invalid suggestion for a reference of iterator #127669

merged 2 commits into from
Jul 16, 2024

Conversation

chenyukang
Copy link
Member

Fixes #127590

@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 12, 2024
chenyukang
chenyukang commented Jul 12, 2024
View reviewed changes
tests/ui/traits/suggest-dereferences/invalid-suggest-deref-issue-127590.stderr
LL + for (src, dest) in std::iter::zip(fields.iter(), variant.iter().clone()) {
|

error[E0277]: `&std::slice::Iter<'_, {integer}>` is not an iterator
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this diag also seems weird, it's better if we could remove it.

@nnethercote
Copy link
Contributor

Could you break this into two commits?

  • First commit adds the new test, with the old test output.
  • Second commit makes the change, and updates the test output.

This makes it much easier to review and see the effect of the change. Thanks!

@chenyukang chenyukang force-pushed the yukang-fix-deref-127590 branch from c8ed5c5 to 5ebfe69 Compare July 16, 2024 14:00
@chenyukang chenyukang force-pushed the yukang-fix-deref-127590 branch from 5ebfe69 to 48ddf5e Compare July 16, 2024 14:02
@nnethercote
Copy link
Contributor

Great, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 16, 2024

📌 Commit 48ddf5e has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2024
@bors
Auto merge of rust-lang#127819 - matthiaskrgr:rollup-djdffkl, r=matth…
16b5690 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#127669 (Fix the issue of invalid suggestion for a reference of iterator)
 - rust-lang#127707 (match lowering: Use an iterator to find `expand_until`)
 - rust-lang#127730 (Fix and enforce `unsafe_op_in_unsafe_fn` in compiler)
 - rust-lang#127789 (delete #![allow(unsafe_op_in_unsafe_fn)] in teeos)
 - rust-lang#127805 (run-make-support: update gimli to 0.31.0)
 - rust-lang#127808 (Make ErrorGuaranteed discoverable outside types, consts, and lifetimes)
 - rust-lang#127817 (Fix a bunch of sites that were walking instead of visiting, making it impossible for visitor impls to look at these values)
 - rust-lang#127818 (Various ast validation simplifications)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5ee4533 into rust-lang:master Jul 16, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2024
@rust-timer
Unrolled build for rust-lang#127669
3ea2502 
Rollup merge of rust-lang#127669 - chenyukang:yukang-fix-deref-127590, r=nnethercote

Fix the issue of invalid suggestion for a reference of iterator

Fixes rust-lang#127590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nnethercote nnethercote

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.

Invalid suggestion for a reference of iterator
4 participants
@chenyukang @rustbot @nnethercote @bors