Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate crate-hash-rustc-version to rmake #127693

Merged
merged 2 commits into from
Jul 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/tools/tidy/src/allowed_run_make_makefiles.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ run-make/cdylib-dylib-linkage/Makefile
run-make/compiler-lookup-paths-2/Makefile
run-make/compiler-lookup-paths/Makefile
run-make/compiler-rt-works-on-mingw/Makefile
run-make/crate-hash-rustc-version/Makefile
run-make/cross-lang-lto-clang/Makefile
run-make/cross-lang-lto-pgo-smoketest/Makefile
run-make/cross-lang-lto-upstream-rlibs/Makefile
Expand Down
38 changes: 0 additions & 38 deletions tests/run-make/crate-hash-rustc-version/Makefile

This file was deleted.

57 changes: 57 additions & 0 deletions tests/run-make/crate-hash-rustc-version/rmake.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
// Ensure that crates compiled with different rustc versions cannot
// be dynamically linked.

//@ ignore-cross-compile
//@ only-unix

use run_make_support::llvm;
use run_make_support::{diff, dynamic_lib_name, is_darwin, run, run_fail, rustc};

fn llvm_readobj() -> llvm::LlvmReadobj {
let mut cmd = llvm::llvm_readobj();
if is_darwin() {
cmd.symbols();
} else {
cmd.dynamic_table();
}
cmd
}

fn main() {
let flags = ["-Cprefer-dynamic", "-Csymbol-mangling-version=v0"];

// a.rs is compiled to a dylib
rustc().input("a.rs").crate_type("dylib").args(&flags).run();

// Store symbols
let symbols_before = llvm_readobj().arg(dynamic_lib_name("a")).run().stdout_utf8();

// b.rs is compiled to a binary
rustc()
.input("b.rs")
.extern_("a", dynamic_lib_name("a"))
.crate_type("bin")
.arg("-Crpath")
.args(&flags)
.run();
run("b");

// Now re-compile a.rs with another rustc version
rustc()
.env("RUSTC_FORCE_RUSTC_VERSION", "deadfeed")
.input("a.rs")
.crate_type("dylib")
.args(&flags)
.run();

// After compiling with a different rustc version, store symbols again.
let symbols_after = llvm_readobj().arg(dynamic_lib_name("a")).run().stdout_utf8();

// As a sanity check, test if the symbols changed:
// If the symbols are identical, there's been an error.
diff()
.expected_text("symbols_before", symbols_before)
.actual_text("symbols_after", symbols_after)
.run_fail();
run_fail("b");
}
Loading