-
Notifications
You must be signed in to change notification settings - Fork 13.3k
collect doc alias as tips during resolution #127721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
In general I'd prefer to maybe not do this at all for the local crate. |
Agree and accept this suggestion. @rustbot ready |
This comment was marked as resolved.
This comment was marked as resolved.
@bvanjoi triage here, any interest in rebasing this? |
@bvanjoi |
Rebased. @rustbot ready |
This comment was marked as resolved.
This comment was marked as resolved.
Update: Fixes the incorrect submodule... |
This comment was marked as resolved.
This comment was marked as resolved.
Hi @estebank could you take a look at this when you get a chance? Thanks 🙂 |
Maybe r? @petrochenkov (or reroll)? |
Some changes occurred in compiler/rustc_attr_parsing |
@rustbot ready |
@rustbot ready |
r=me with an explanation #127721 (comment), not just for rev but for what the code intends to do in general. |
Reminder, once the PR becomes ready for a review, use |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment has been minimized.
This comment has been minimized.
@bors r+ |
Close #124273
Collect the symbol in the doc alias attributes and provide a tip when a match is found.
r? @estebank