deps: dedup object, wasmparser, wasm-encoder #127860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
|
The run-make-support library was changed cc @jieyouxu These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
A-run-make
klensy
changed the title
This comment has been minimized.
This comment has been minimized.
|
@rustbot author |
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
|
|
rustbot
added
A-testsuite
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. Some changes occurred in src/tools/compiletest cc @jieyouxu |
|
Sorry for ping, wrong rebase. |
|
@rustbot ready there was an issue with |
rustbot
added
S-waiting-on-review
philipc
reviewed
Jul 24, 2024
|
r=me with some squashing/cleanup |
waiting on thorin-dwp update dedup one wasmparser run-make-support: drop some features for wasmparser dedupe wasm-encoder
adopt wasm_encoder changes
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 28, 2024
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#125779 ([rustdoc] Add copy code feature) - rust-lang#127765 (Fix doc nits) - rust-lang#127860 (deps: dedup object, wasmparser, wasm-encoder) - rust-lang#128103 (add `is_multiple_of` for unsigned integer types) - rust-lang#128228 (Stabilize `const_waker`) - rust-lang#128240 (Add links from `assert_eq!` docs to `debug_assert_eq!`, etc.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 28, 2024
Rollup merge of rust-lang#127860 - klensy:dedup, r=Mark-Simulacrum deps: dedup object, wasmparser, wasm-encoder * dedups one `object`, additional dupe will be removed, with next `thorin-dwp` update * `wasmparser` pinned to minor versions, so full merge isn't possible * same with `wasm-encoder` Turned off some features for `wasmparser` (see features https://github.com/bytecodealliance/wasm-tools/blob/v1.208.1/crates/wasmparser/Cargo.toml) in `run-make-support`, looks working?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object, additional dupe will be removed, with nextthorin-dwpupdatewasmparserpinned to minor versions, so full merge isn't possiblewasm-encoderTurned off some features for
wasmparser(see features https://github.com/bytecodealliance/wasm-tools/blob/v1.208.1/crates/wasmparser/Cargo.toml) inrun-make-support, looks working?