Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ICE with incorrect empty suggestion #127988

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Do not ICE with incorrect empty suggestion #127988

merged 2 commits into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. Do not ICE with incorrect empty suggestion 

    When we have two types with the same name, one without type parameters and the other with type parameters and a derive macro, we were before incorrectly suggesting to remove type parameters from the former, which ICEd because we were suggesting to remove nothing. We now gate against this.

The output is still not perfect. E0107 should explicitly detect this case and provide better context, but for now let's avoid the ICE.
    @estebank @fmease
    estebank authored and fmease committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    bd8e88f View commit details
    Browse the repository at this point in the history

  2. Explicitly mark a hack as a HACK and elaborate its comment

    @fmease
    fmease committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    682c5f4 View commit details
    Browse the repository at this point in the history