Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic: Use local functions in panic! whenever possible #128068

Closed
wants to merge 12 commits into from
Closed

panic: Use local functions in panic! whenever possible #128068

wants to merge 12 commits into from

Commits on Jul 22, 2024

  1. panic: Use local functions in panic! whenever possible 

    This is basically extending the idea implemented in `panic_2021!`.

By creating a cold/noinline function that wraps the setup for the call
to the internal panic function moves more of the code-size cost of
`panic!` to the cold path.

For example: https://godbolt.org/z/T1ndrcq4d
    @goldsteinn
    goldsteinn committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    ca16524 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Comments + Fixup to std::panic_2015

    @goldsteinn
    goldsteinn committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cc107fc View commit details
    Browse the repository at this point in the history

  2. Remove internal feature from std::panic

    @goldsteinn
    goldsteinn committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    11caff4 View commit details
    Browse the repository at this point in the history

  3. make {} special case non-const in std::panic_2015

    @goldsteinn
    goldsteinn committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f2f77f2 View commit details
    Browse the repository at this point in the history

  4. fix core::unreachable_2021!

    @goldsteinn
    goldsteinn committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a59b918 View commit details
    Browse the repository at this point in the history

  5. Allow const_format_args in core::unreachable_2021!

    @goldsteinn
    goldsteinn committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    af6260f View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Fixup tests

    @goldsteinn
    goldsteinn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6a4f226 View commit details
    Browse the repository at this point in the history

  2. Drop TODO

    @goldsteinn
    goldsteinn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6cbc3eb View commit details
    Browse the repository at this point in the history

  3. Fixup clippy test

    @goldsteinn
    goldsteinn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7219ce0 View commit details
    Browse the repository at this point in the history

  4. Move explicit panic/unreachable into panicking.rs

    @goldsteinn
    goldsteinn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    555a033 View commit details
    Browse the repository at this point in the history

  5. Fix clippy tests

    @goldsteinn
    goldsteinn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    12e23c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Fixup tests

    @goldsteinn
    goldsteinn committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    b8d3c62 View commit details
    Browse the repository at this point in the history