Skip to content

android: Remove libstd hacks for unsupported Android APIs #128416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

maurer
Copy link
Contributor

@maurer maurer commented Jul 30, 2024

Our minimum supported API version is 21, remove hacks to support older Android APIs.

try-job: arm-android

r? tgross35

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 30, 2024
@tgross35
Copy link
Contributor

@bors try

@bors
Copy link
Collaborator

bors commented Jul 30, 2024

⌛ Trying commit 6357d41 with merge 7387c4d...

@rust-log-analyzer

This comment has been minimized.

@tgross35
Copy link
Contributor

This actually needs an update in std too, the function from intrinsics can be called directly at

crate::sys::log2f32(self)
(and f64).

@maurer maurer force-pushed the remove-android-hack branch from 6357d41 to 6586619 Compare July 30, 2024 23:58
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@tgross35
Copy link
Contributor

Whoops, didn't see the new push.

@bors try

@bors
Copy link
Collaborator

bors commented Jul 31, 2024

⌛ Trying commit 6586619 with merge 882d1d7...

Our minimum supported API version is 21, remove hacks to support older
Android APIs.
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jul 31, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2024
@maurer maurer force-pushed the remove-android-hack branch from 6586619 to 7d7ad7b Compare July 31, 2024 02:22
@tgross35
Copy link
Contributor

@bors try

@bors
Copy link
Collaborator

bors commented Jul 31, 2024

⌛ Trying commit 7d7ad7b with merge a1f698b...

@bors
Copy link
Collaborator

bors commented Jul 31, 2024

☀️ Try build successful - checks-actions
Build commit: a1f698b (a1f698bf5fd552e9013ef83aff9fcce58b0fc33f)

@tgross35
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 31, 2024

📌 Commit 7d7ad7b has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2024
@bors bors merged commit 0cda002 into rust-lang:master Aug 1, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants