Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #128508

Closed
wants to merge 23 commits into from
Closed

Commits on Jul 30, 2024

  1. Revert "Rollup merge of rust-lang#128104 - mu001999-contrib:fix/12805…

    …3, r=petrochenkov"
    
    This reverts commit 91b18a0, reversing
    changes made to 9aedec9.
    compiler-errors committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    efdf219 View commit details
    Browse the repository at this point in the history
  2. Revert "Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enha…

    …nce, r=pnkfelix"
    
    This reverts commit a70dc29, reversing
    changes made to ceae371.
    compiler-errors committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8a0cd61 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Inline and remove parse_local_mk.

    It has a single use. This makes the `let` handling case in
    `parse_stmt_without_recovery` more similar to the statement path and
    statement expression cases.
    nnethercote committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    281c2fd View commit details
    Browse the repository at this point in the history
  2. Remove LhsExpr.

    `parse_expr_assoc_with` has an awkward structure -- sometimes the lhs is
    already parsed. This commit splits the post-lhs part into a new method
    `parse_expr_assoc_rest_with`, which makes everything shorter and
    simpler.
    nnethercote committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    fe647f0 View commit details
    Browse the repository at this point in the history
  3. Revert "Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enha…

    …nce-2, r=pnkfelix"
    
    This reverts commit 31fe962, reversing
    changes made to f203078.
    compiler-errors committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    641ba86 View commit details
    Browse the repository at this point in the history
  4. Revert "Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enha…

    …nce, r=pnkfelix"
    
    This reverts commit 2724aea, reversing
    changes made to d929a42.
    compiler-errors committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e5667ac View commit details
    Browse the repository at this point in the history
  5. Revert "Rollup merge of rust-lang#126315 - mu001999-contrib:fix/12628…

    …9, r=petrochenkov"
    
    This reverts commit 977c5fd, reversing
    changes made to 24c94f0.
    compiler-errors committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    cd6c8cc View commit details
    Browse the repository at this point in the history
  6. Revert "Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enha…

    …nce, r=pnkfelix"
    
    This reverts commit 13314df, reversing
    changes made to 6e534c7.
    compiler-errors committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7581397 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6f48a64 View commit details
    Browse the repository at this point in the history
  8. Bless test fallout

    compiler-errors committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b1a5e07 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Streamline attribute stitching on AST nodes.

    It can be done more concisely.
    nnethercote committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    2eb2ef1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d77d17 View commit details
    Browse the repository at this point in the history
  3. Distinguish the two kinds of token range.

    When collecting tokens there are two kinds of range:
    - a range relative to the parser's full token stream (which we get when
      we are parsing);
    - a range relative to a single AST node's token stream (which we use
      within `LazyAttrTokenStreamImpl` when replacing tokens).
    
    These are currently both represented with `Range<u32>` and it's easy to
    mix them up -- until now I hadn't properly understood the difference.
    
    This commit introduces `ParserRange` and `NodeRange` to distinguish
    them. This also requires splitting `ReplaceRange` in two, giving the new
    types `ParserReplacement` and `NodeReplacement`. (These latter two names
    reduce the overloading of the word "range".)
    
    The commit also rewrites some comments to be clearer.
    
    The end result is a little more verbose, but much clearer.
    nnethercote committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d1f05fd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6d312d7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    52a49d9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    73ac5e0 View commit details
    Browse the repository at this point in the history
  7. Update stdarch

    sayantn committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f373ff3 View commit details
    Browse the repository at this point in the history
  8. Delete issue-120720-reduce-nan.rs

    This file tests for UB in `reduce_add`, but those are reimplemented by explicitly using the associativity specified by Intel
    sayantn committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    e3b9851 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#127276 - aDotInTheVoid:no-opaque, r=camelid

    rustdoc: Remove OpaqueTy
    
    r? `@ghost`
    
    Apparently this works lol?!?
    
    try-job: aarch64-apple
    tgross35 authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    44ccae1 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#128404 - compiler-errors:revert-dead-code-c…

    …hanges, r=pnkfelix
    
    Revert recent changes to dead code analysis
    
    This is a revert to recent changes to dead code analysis, namely:
    * efdf219 Rollup merge of rust-lang#128104 - mu001999-contrib:fix/128053, r=petrochenkov
    * a70dc29 Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enhance, r=pnkfelix
    * 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
    * 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
    * 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
    * 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
    
    There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this `AnonPipe` type is not publically reachable -- please correct me if I'm wrong cc `@NobodyXu` who added these in #rust-lang#127153.
    
    Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?
    
    I apologize for the size of the PR and the churn that it has on the codebase (and for reverting `@mu001999's` work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.
    
    cc `@mu001999`
    r? `@pnkfelix`
    
    Fixes rust-lang#128272
    Fixes rust-lang#126169
    tgross35 authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    bc9ccee View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#128466 - sayantn:stdarch-update, r=tgross35

    Update the stdarch submodule
    
    cc `@tgross35` `@Amanieu`
    r? `@tgross35`
    
    try-job: x86_64-rust-for-linux
    tgross35 authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b1c7ae0 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#128483 - nnethercote:still-more-cfg-cleanup…

    …s, r=petrochenkov
    
    Still more `cfg` cleanups
    
    Found while looking closely at `cfg`/`cfg_attr` processing code.
    
    r? `@petrochenkov`
    tgross35 authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7a7ca4e View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#128494 - RalfJung:mir-lazy-lists, r=compile…

    …r-errors
    
    MIR required_consts, mentioned_items: ensure we do not forget to fill these lists
    
    Bodies initially get created with empty required_consts and mentioned_items, but at some point those should be filled. Make sure we notice when that is forgotten.
    tgross35 authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    8844e08 View commit details
    Browse the repository at this point in the history