Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Remove dead opaque_tys rendering logic #128521

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

aDotInTheVoid
Copy link
Member

#127276 removed OpaqueTy from clean, and the code populating AllTypes::opaque_tys, but not this field itself.

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2024

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 1, 2024
@aDotInTheVoid aDotInTheVoid added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Aug 1, 2024
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camelid
Copy link
Member

camelid commented Aug 1, 2024

r? @camelid
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 1, 2024

📌 Commit b72685b has been approved by camelid

It is now in the queue for this repository.

@rustbot rustbot assigned camelid and unassigned fmease Aug 1, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 2, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126818 (Better handle suggestions for the already present code and fix some suggestions)
 - rust-lang#128436 (Update sysinfo version to 0.31.2)
 - rust-lang#128453 (raw_eq: using it on bytes with provenance is not UB (outside const-eval))
 - rust-lang#128491 ([`macro_metavar_expr_concat`] Dogfooding)
 - rust-lang#128494 (MIR required_consts, mentioned_items: ensure we do not forget to fill these lists)
 - rust-lang#128521 (rustdoc: Remove dead opaque_tys rendering logic)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1140fd1 into rust-lang:master Aug 2, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 2, 2024
Rollup merge of rust-lang#128521 - aDotInTheVoid:opaque-fallout, r=camelid

rustdoc: Remove dead opaque_tys rendering logic

rust-lang#127276 removed OpaqueTy from clean, and the code populating AllTypes::opaque_tys, but not this field itself.
@rustbot rustbot added this to the 1.82.0 milestone Aug 2, 2024
@aDotInTheVoid aDotInTheVoid deleted the opaque-fallout branch August 3, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants