Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use shorthand initializer #128557

Merged
merged 1 commit into from
Aug 3, 2024
Merged

chore: use shorthand initializer #128557

merged 1 commit into from
Aug 3, 2024

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Aug 2, 2024

Tiny readability improvement - don't use redundant initializer vars

@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 2, 2024
compiler-errors
compiler-errors requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally you should not touch tests when applying changes to the rust repo. Pls revert those changes.

@nyurik
Copy link
Contributor Author

nyurik commented Aug 2, 2024

@compiler-errors fair point, reverted, thx

@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 2, 2024

📌 Commit 84e261e has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned cjgillot Aug 2, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 2, 2024
@jieyouxu
Rollup merge of rust-lang#128557 - nyurik:dup-init, r=compiler-errors
7613285 
chore: use shorthand initializer

Tiny readability improvement - don't use redundant initializer vars
@jieyouxu jieyouxu mentioned this pull request Aug 2, 2024
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 2, 2024
@jieyouxu
Rollup merge of rust-lang#128557 - nyurik:dup-init, r=compiler-errors
2d4f3ea 
chore: use shorthand initializer

Tiny readability improvement - don't use redundant initializer vars
@jieyouxu jieyouxu mentioned this pull request Aug 2, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 2, 2024
@bors
Auto merge of rust-lang#128575 - jieyouxu:rollup-wet6vjy, r=jieyouxu
efc8b46 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#126704 (Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate)
 - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake)
 - rust-lang#128107 (Migrate `raw-dylib-alt-calling-convention`, `raw-dylib-c` and `redundant-libs` `run-make` tests to rmake)
 - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests)
 - rust-lang#128356 (Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake)
 - rust-lang#128404 (Revert recent changes to dead code analysis)
 - rust-lang#128483 (Still more `cfg` cleanups)
 - rust-lang#128528 (Finish removing `has_cpuid`)
 - rust-lang#128557 (chore: use shorthand initializer)

r? `@ghost`
`@rustbot` modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 3, 2024
@jieyouxu
Rollup merge of rust-lang#128557 - nyurik:dup-init, r=compiler-errors
31db40d 
chore: use shorthand initializer

Tiny readability improvement - don't use redundant initializer vars
@jieyouxu jieyouxu mentioned this pull request Aug 3, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2024
@bors
Auto merge of rust-lang#128577 - jieyouxu:rollup-uejer3g, r=jieyouxu
24f99cb 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#126704 (Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate)
 - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake)
 - rust-lang#127586 (Add `#[must_use]` to some `into_raw*` functions.)
 - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests)
 - rust-lang#128303 (Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}`)
 - rust-lang#128356 (Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake)
 - rust-lang#128368 (Formatting tweaks)
 - rust-lang#128404 (Revert recent changes to dead code analysis)
 - rust-lang#128483 (Still more `cfg` cleanups)
 - rust-lang#128557 (chore: use shorthand initializer)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2024
@bors
Auto merge of rust-lang#128577 - jieyouxu:rollup-uejer3g, r=jieyouxu
eded52c 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#126704 (Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate)
 - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake)
 - rust-lang#127586 (Add `#[must_use]` to some `into_raw*` functions.)
 - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests)
 - rust-lang#128303 (Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}`)
 - rust-lang#128356 (Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake)
 - rust-lang#128368 (Formatting tweaks)
 - rust-lang#128404 (Revert recent changes to dead code analysis)
 - rust-lang#128483 (Still more `cfg` cleanups)
 - rust-lang#128557 (chore: use shorthand initializer)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2024
@bors
Auto merge of rust-lang#128595 - matthiaskrgr:rollup-7a4qa8b, r=matth…
ad0a2b7 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#126704 (Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate)
 - rust-lang#127586 (Add `#[must_use]` to some `into_raw*` functions.)
 - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests)
 - rust-lang#128303 (Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}`)
 - rust-lang#128368 (Formatting tweaks)
 - rust-lang#128483 (Still more `cfg` cleanups)
 - rust-lang#128557 (chore: use shorthand initializer)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9b69042 into rust-lang:master Aug 3, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 3, 2024
@rust-timer
Unrolled build for rust-lang#128557
c9f7aaf 
Rollup merge of rust-lang#128557 - nyurik:dup-init, r=compiler-errors

chore: use shorthand initializer

Tiny readability improvement - don't use redundant initializer vars
@rustbot rustbot added this to the 1.82.0 milestone Aug 3, 2024
@nyurik nyurik deleted the dup-init branch August 3, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@compiler-errors compiler-errors

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nyurik @rustbot @compiler-errors @bors @cjgillot