rustdoc-search: account for numeric disambiguators on impls #128693
Merged
+52
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notriddle
added
the
T-rustdoc-frontend
|
rustbot has assigned @GuillaumeGomez. Use |
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha Some changes occurred in GUI tests. |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/impl-disambiguator-2024
branch
from
ab4b438 to
34928c8
Compare
notriddle
force-pushed
the
notriddle/impl-disambiguator-2024
branch
from
34928c8 to
d4f12d6
Compare
notriddle
force-pushed
the
notriddle/impl-disambiguator-2024
branch
from
d4f12d6 to
3a18325
Compare
GuillaumeGomez
approved these changes
Aug 6, 2024
|
Looks good to me, thanks! r=me once CI pass. |
|
@bors r=GuillaumeGomez |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 6, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#128369 (rustc_lint: make `let-underscore-lock` translatable) - rust-lang#128377 (Fix ICE Caused by Incorrectly Delaying E0107) - rust-lang#128517 (Fallback to string formatting if source is not available for lint) - rust-lang#128685 (Remove the root Cargo.lock from the rust-src component) - rust-lang#128693 (rustdoc-search: account for numeric disambiguators on impls) - rust-lang#128720 (Pass the right `ParamEnv` to `might_permit_raw_init_strict`) - rust-lang#128736 (Fix rustdoc missing handling of remap-path-prefix option) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2024
Rollup merge of rust-lang#128693 - notriddle:notriddle/impl-disambiguator-2024, r=GuillaumeGomez rustdoc-search: account for numeric disambiguators on impls Fixes rust-lang#128676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128676