remove unnecessary tidy ignore

[yaahc]

Right now when I run x test on master I get an error about an unnecessary ignore directive for CR characters from a rustdoc file.

Removing the ignore directive resolves the issue

❯ x test
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s
WARNING: build directory locked by process 70531, waiting for lock
Building stage0 tool tidy (x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized + debuginfo] target(s) in 0.09s
fmt check
fmt: checked 5427 modified files
tidy check
tidy error: ~/git/rust-lang/rust/tests/rustdoc-ui/intra-doc/warning-crlf.rs: ignoring CR characters unnecessarily
some tidy checks failed

This seems to be an interaction between .gitattributes and jj which I'm using to manage my git repo locally

jj-vcs/jj#53

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rust-log-analyzer]

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#13 2.817 Building wheels for collected packages: reuse
#13 2.818   Building wheel for reuse (pyproject.toml): started
#13 3.066   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.067   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132715 sha256=dfa09868353292d98f811d3efdb0d54d07389e808efc71d68e3b93c514bf8bec
#13 3.068   Stored in directory: /tmp/pip-ephem-wheel-cache-x_ml65u9/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#13 3.071 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#13 3.472 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#13 3.473 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.009 Collecting virtualenv
#13 4.009 Collecting virtualenv
#13 4.060   Downloading virtualenv-20.26.3-py3-none-any.whl (5.7 MB)
#13 4.282      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.7/5.7 MB 25.8 MB/s eta 0:00:00
#13 4.337 Collecting platformdirs<5,>=3.9.1
#13 4.345   Downloading platformdirs-4.2.2-py3-none-any.whl (18 kB)
#13 4.366 Collecting distlib<1,>=0.3.7
#13 4.385      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 56.5 MB/s eta 0:00:00
#13 4.423 Collecting filelock<4,>=3.12.2
#13 4.432   Downloading filelock-3.15.4-py3-none-any.whl (16 kB)
#13 4.432   Downloading filelock-3.15.4-py3-none-any.whl (16 kB)
#13 4.512 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 4.713 Successfully installed distlib-0.3.8 filelock-3.15.4 platformdirs-4.2.2 virtualenv-20.26.3
#13 DONE 4.8s

#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k:      210880 kB
DirectMap2M:     7129088 kB
DirectMap1G:    11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint,cpp:fmt
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/f7eefec4e03f5ba723fbc04d94dbc1203b7c9bff/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-f7eefec4e03f5ba723fbc04d94dbc1203b7c9bff-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
fmt check
fmt: checked 5428 files
tidy check
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:1: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:2: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:3: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:4: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:5: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:6: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:7: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:8: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:9: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:10: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:11: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:12: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:13: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:14: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:15: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:16: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:17: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:18: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:19: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:20: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:21: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:22: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:23: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:24: CR character
##[error]tidy error: /checkout/tests/rustdoc-ui/intra-doc/warning-crlf.rs:25: CR character
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (24.1)
  Downloading pip-24.2-py3-none-any.whl.metadata (3.6 kB)
Downloading pip-24.2-py3-none-any.whl (1.8 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.8/1.8 MB 6.2 MB/s eta 0:00:00
Installing collected packages: pip
---
All checks passed!
checking C++ file formatting
some tidy checks failed

Command LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-tidy" "/checkout" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build" "4" "--extra-checks=py:lint,cpp:fmt" (failure_mode=DelayFail) did not execute successfully.
Created at: src/core/build_steps/tool.rs:1113:23
Executed at: src/core/build_steps/test.rs:1078:29

Build completed unsuccessfully in 0:01:19