Specify a minimum supported version for VxWorks #128758
Conversation
|
rustbot has assigned @GuillaumeGomez. Use |
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
|
r? tgross35 |
|
This PR seeks to specify a minimum supported version of VxWorks to 7 to make it more obvious which APIs should be considered usable. Does this seem reasonable, or should a different version be specified? Asking some people who have contributed to vxworks here or in libc, please comment or thumbs up if the proposed version seems good: @biabbas @jdygert-spok @NicholasBaron @BaoshanPang Some more context is at #128758 (also, it would be good to have one or two more listed maintainers for VxWorks, which just means you can get pinged when platform-specific questions come up. If anyone here is interested, just submit a PR updating |
| @@ -20,6 +20,12 @@ Target triplets available: | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| ### OS version | |||
|
|
|||
| The minimum supported version is VxWorks 7 on x86/64 and ARM64. | |||
There was a problem hiding this comment.
Why are the architectures specified - is something different for ppc and arm32?
There was a problem hiding this comment.
Minimum supported version of OS would be the same for all VxWorks supported architectures. Although PowerPC targets are not an active consideration during Rust for VxWorks development.
Note:
#128545
There was a problem hiding this comment.
Thanks for confirming. @devnexen could you drop the "on x86/64 and ARM64" unless there is a specific reason?
There was a problem hiding this comment.
@biabbas does this minimum version seem reasonable to you?
Also, could someone confirm when this version (VxWorks 7) was released? I am having some trouble figuring this out online what the oldest supported version will be.
There was a problem hiding this comment.
I think VxWorks 7 was released in 2016. Rust was enable for VxWorks in 2019(#61946 ). I've only worked on VxWorks 7.
There was a problem hiding this comment.
I think Versions older than VxWorks7 would require porting efforts, minimum supported version should be VxWorks7.
But since we would have to go through the changes from VxWorks 6 to VxWorks 7 to confirm the minimum supported version. This seems less reasonable now.
There was a problem hiding this comment.
I think your PR should be merged first.
There was a problem hiding this comment.
@devnexen
Do you have access to VxWorks 6 workbench?
There was a problem hiding this comment.
Thanks for confirming. @devnexen could you drop the "on x86/64 and ARM64" unless there is a specific reason?
After these changes, this pr would be good for now.
|
Just to clarify this should get some feedback before merge: @rustbot blocked |
rustbot
added
S-blocked
tgross35
changed the title
tgross35
changed the title
I'm not sure if anyone else is also working on VxWorks rust, thus no one else is listed as a maintainer. |
devnexen
force-pushed
the
vxworks_release_min
branch
2 times, most recently
from
27f029e
to
00800bc
Compare
devnexen
force-pushed
the
vxworks_release_min
branch
from
00800bc
to
c8eacd6
Compare
|
If the specified version is from 2016, I think it is pretty unobjectionable. That is pretty similar to our oldest MacOS (10.12, 2016) and Windows (10, 2015). If there are any problems we can revisit, but this should make the ongoing Thanks for getting this documented. @bors r+ rollup |
bors
added
S-waiting-on-bors
…ross35 Specify a minimum supported version for VxWorks Document that VxWorks 7 is the minimum supported version.
Rollup of 7 pull requests Successful merges: - rust-lang#128206 (Make create_dll_import_lib easier to implement) - rust-lang#128221 (Add implied target features to target_feature attribute) - rust-lang#128384 (Add tests to ensure MTE tags are preserved across FFI boundaries) - rust-lang#128656 (Enable msvc for run-make/rust-lld) - rust-lang#128691 (Update `compiler-builtins` to 0.1.117) - rust-lang#128700 (Migrate `simd-ffi` `run-make` test to rmake) - rust-lang#128758 (Specify a minimum supported version for VxWorks) r? `@ghost` `@rustbot` modify labels: rollup
…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#128206 (Make create_dll_import_lib easier to implement) - rust-lang#128424 (minor `effects` cleanups) - rust-lang#128527 (More information for fully-qualified suggestion when there are multiple impls) - rust-lang#128656 (Enable msvc for run-make/rust-lld) - rust-lang#128683 (bootstrap: clear miri's ui test deps when rustc changes) - rust-lang#128700 (Migrate `simd-ffi` `run-make` test to rmake) - rust-lang#128753 (Don't arbitrarily choose one upper bound for hidden captured region error message) - rust-lang#128757 (Migrate `pgo-gen-lto` `run-make` test to rmake) - rust-lang#128758 (Specify a minimum supported version for VxWorks) Failed merges: - rust-lang#128679 (codegen: better centralize function declaration attribute computation) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128758 - devnexen:vxworks_release_min, r=tgross35 Specify a minimum supported version for VxWorks Document that VxWorks 7 is the minimum supported version.
Document that VxWorks 7 is the minimum supported version.