Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracking issue to core-pattern-type #128800

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add tracking issue to core-pattern-type #128800

merged 1 commit into from
Aug 8, 2024

Conversation

clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented Aug 7, 2024 •
edited
Loading

While the actual pattern_types feature flag has an issue assigned, the exported macro and its module do not.

cc #123646

@rustbot
Copy link
Collaborator

rustbot commented Aug 7, 2024

Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Aug 7, 2024

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 7, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@clarfonthey
Copy link
Contributor Author

clarfonthey commented Aug 7, 2024 •
edited
Loading

(hadn't considered it'd mess up the error messages, so, I'm currently running blessing procedure and will be back next year when it finishes)

@compiler-errors
Copy link
Member

Please squash this into one commit.

Also, @oli-obk I know you're gone but maybe you'll see this -- do you (or anyone, for the record) know why we have core_pattern_type and core_pattern_types as separate feature gates?

@clarfonthey
Copy link
Contributor Author

clarfonthey commented Aug 8, 2024 •
edited
Loading

Wasn't aware that we were requiring squashes now, but I'll be sure to keep that in mind. (Sometimes they can make reviewing harder.)

I figured that the two separate feature flags was due to the fact that the core::pat module is only temporary to avoid name collisions, like why std::assert_matches (the module) exists. But it wasn't super important to me, which is why I left them as-is.

@compiler-errors
Copy link
Member

No, we don't require squashes as policy or anything. Commits are typically useful when they actually meaningfully break up work or are a meaningful difference to review, but this PR is 4 files changed, so it's probably not worth it.

@clarfonthey
Copy link
Contributor Author

Fair. I usually squash-push for tiny changes like this but didn't in this particular instance. I don't think it matters too much, but if you would prefer to squash, I'll squash.

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 8, 2024

📌 Commit 0257f42 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2024
@compiler-errors
Copy link
Member

@bors rollup

@tgross35 tgross35 mentioned this pull request Aug 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2024
@bors
Auto merge of rust-lang#128805 - tgross35:rollup-wajzi6w, r=tgross35
Loading
Loading status checks…
9337f7a 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#128520 (Skip over args when determining if async-closure's inner coroutine consumes its upvars)
 - rust-lang#128552 (Emit an error for invalid use of the `#[no_sanitize]` attribute)
 - rust-lang#128691 (Update `compiler-builtins` to 0.1.117)
 - rust-lang#128702 (Add -Zmetrics-dir=PATH to save diagnostic metadata to disk)
 - rust-lang#128797 (Fuchsia Test Runner: enable ffx repository server)
 - rust-lang#128798 (refactor(rustc_expand::mbe): Don't require full ExtCtxt when not necessary)
 - rust-lang#128800 (Add tracking issue to core-pattern-type)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 36b9aee into rust-lang:master Aug 8, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2024
@rust-timer
Unrolled build for rust-lang#128800
Loading
Loading status checks…
0f72cba 
Rollup merge of rust-lang#128800 - clarfonthey:core-pattern-type, r=compiler-errors

Add tracking issue to core-pattern-type

While the actual `pattern_types` feature flag has an issue assigned, the exported macro and its module do not.

cc rust-lang#123646
@rustbot rustbot added this to the 1.82.0 milestone Aug 8, 2024
@clarfonthey clarfonthey deleted the core-pattern-type branch August 8, 2024 10:33
@jieyouxu
Copy link
Member

do you (or anyone, for the record) know why we have core_pattern_type and core_pattern_types as separate feature gates?

pinging back to #128987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
7 participants
@clarfonthey @rustbot @rust-log-analyzer @compiler-errors @bors @jieyouxu @scottmcm