Skip to content

Only suggest #[allow] for --warn and --deny lint level flags #128826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

Only suggest #[allow] for --warn and --deny lint level flags #128826

merged 1 commit into from
Aug 8, 2024

Conversation

Alexendoo
Copy link
Member

--force-warn and --forbid cannot be overridden

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2024
compiler-errors
compiler-errors approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@compiler-errors
Copy link
Member

Thanks

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 8, 2024

📌 Commit 9289f56 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#128826 - Alexendoo:lint-override-suggestion…
f92c323 
…s, r=compiler-errors

Only suggest `#[allow]` for `--warn` and `--deny` lint level flags

`--force-warn` and `--forbid` cannot be overridden
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 8, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2024
@bors
Auto merge of rust-lang#128829 - matthiaskrgr:rollup-kbkjllg, r=matth…
71f4439 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#128306 (Update NonNull::align_offset quarantees)
 - rust-lang#128612 (Make `validate_mir` ensure the final MIR for all bodies)
 - rust-lang#128648 (Add regression test)
 - rust-lang#128791 (Don't implement `AsyncFn` for `FnDef`/`FnPtr` that wouldnt implement `Fn`)
 - rust-lang#128795 (Update E0517 message to reflect RFC 2195.)
 - rust-lang#128825 (rm `declared_features` field in resolver)
 - rust-lang#128826 (Only suggest `#[allow]` for `--warn` and `--deny` lint level flags)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2024
@bors
Auto merge of rust-lang#128835 - matthiaskrgr:rollup-apzlbxy, r=matth…
3e9bd8b 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#128306 (Update NonNull::align_offset quarantees)
 - rust-lang#128612 (Make `validate_mir` ensure the final MIR for all bodies)
 - rust-lang#128648 (Add regression test)
 - rust-lang#128749 (Mark `{f32,f64}::{next_up,next_down,midpoint}` inline)
 - rust-lang#128795 (Update E0517 message to reflect RFC 2195.)
 - rust-lang#128825 (rm `declared_features` field in resolver)
 - rust-lang#128826 (Only suggest `#[allow]` for `--warn` and `--deny` lint level flags)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 70dccc2 into rust-lang:master Aug 8, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2024
@rust-timer
Unrolled build for rust-lang#128826
1f1b832 
Rollup merge of rust-lang#128826 - Alexendoo:lint-override-suggestions, r=compiler-errors

Only suggest `#[allow]` for `--warn` and `--deny` lint level flags

`--force-warn` and `--forbid` cannot be overridden
@rustbot rustbot added this to the 1.82.0 milestone Aug 8, 2024
@Alexendoo Alexendoo deleted the lint-override-suggestions branch August 8, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Alexendoo @rustbot @compiler-errors @bors @wesleywiser