Skip to content

Conversation

its-the-shrimp
Copy link
Contributor

Modules are now stripped based on the same logic that's used to strip other item kinds
Fixes #101105

modules are now stripped based on the same logic that's used to strip other item kinds
@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2024

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 8, 2024
@its-the-shrimp
Copy link
Contributor Author

r? @aDotInTheVoid

@rustbot rustbot assigned aDotInTheVoid and unassigned notriddle Aug 8, 2024
@aDotInTheVoid
Copy link
Member

Thanks!

r=me when CI passes

@bors delegate+

@bors
Copy link
Collaborator

bors commented Aug 8, 2024

✌️ @its-the-shrimp, you can now approve this pull request!

If @aDotInTheVoid told you to "r=me" after making some further change, please make that change, then do @bors r=@aDotInTheVoid

@its-the-shrimp
Copy link
Contributor Author

@bors r=@aDotInTheVoid

@bors
Copy link
Collaborator

bors commented Aug 8, 2024

📌 Commit c2a0d9c has been approved by aDotInTheVoid

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 8, 2024
…nTheVoid

rustdoc: strip unreachable modules

Modules are now stripped based on the same logic that's used to strip other item kinds
Fixes rust-lang#101105
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#128640 (rwlock: disable 'frob' test in Miri on macOS)
 - rust-lang#128791 (Don't implement `AsyncFn` for `FnDef`/`FnPtr` that wouldnt implement `Fn`)
 - rust-lang#128806 (Split `ColorConfig` off of `HumanReadableErrorType`)
 - rust-lang#128818 (std float tests: special-case Miri in feature detection)
 - rust-lang#128834 (rustdoc: strip unreachable modules)
 - rust-lang#128836 (rustdoc-json: add a test for impls on private & hidden types)
 - rust-lang#128837 (Clippy subtree update)
 - rust-lang#128851 (Add comment that bors did not see pushed before it merged)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5e388ea into rust-lang:master Aug 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 9, 2024
Rollup merge of rust-lang#128834 - its-the-shrimp:fix_101105, r=aDotInTheVoid

rustdoc: strip unreachable modules

Modules are now stripped based on the same logic that's used to strip other item kinds
Fixes rust-lang#101105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc-Json: Pub mod in private mod adds both to index
5 participants