-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port rustc perf cmp command #128868
Port rustc perf cmp command #128868
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
|
r? @Kobzol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks great! Left a few comments.
4713ef9
to
83363f2
Compare
Thanks! I've fixed them. |
83363f2
to
ce1d7d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, works great!
Idea for improving bench_cmp
: if you don't specify IDs, it could show the two latest artifacts in the DB. If you specify only one, it should compare that ID with the latest (different) artifact in the DB.
@bors r+ rollup |
Actually, this updates @bors rollup=never |
That's definitely useful! I'm going to impl it. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e9e27ab): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -1.6%, secondary -1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 751.195s -> 753.953s (0.37%) |
This is most probably caused by small perturbances caused by the rustc-perf update. @rustbot label: +perf-regression-triaged |
I've integrated bench_cmp and bench_local into the bootstrap.
r? @Kobzol