Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IGNORE] Tidy up dump-ice-to-disk and make assertion failures dump ICE messages #128960

Closed
wants to merge 1 commit into from

Conversation

jieyouxu
Copy link
Member

Same PR as #128916 but the other one was cursed.

For the future traveler: if you did a git blame and found this PR that last modified dump-ice-to-disk because the test failed in a completely unrelated PR, then I'm afraid our ICE dump regressed.

A bit of clean up to the dump-ice-to-disk test.

Contains a fix by @saethlin in #128909, should wait until that is merged then rebase on top.

r? @compiler-errors (since you reviewed #128916)

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2024
@jieyouxu
Copy link
Member Author

... bors must be really confused by the draft PR that I'm running to test separately...

@jieyouxu jieyouxu closed this Aug 11, 2024
@jieyouxu jieyouxu changed the title Tidy up dump-ice-to-disk and make assertion failures dump ICE messages [IGNORE] Tidy up dump-ice-to-disk and make assertion failures dump ICE messages Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants