-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable more debuginfo tests on freebsd #128990
Conversation
@bors try |
…<try> Re-enable debuginfo tests on freebsd r? `@ghost` try-job: dist-various-2 try-job: dist-x86_64-freebsd
☀️ Try build successful - checks-actions |
Same here, these two runners don't actually run any tests. In fact I don't think that we even run any tests for FreeBSD, as it's not a tier 1 target. |
Well I think the freebsd comment dates back to #23310 so I think removing the ignores anyway is the right move. We don't have a target maintainer listed for any freebsd targets anyway, so I don't see any other way these ignores would get removed. |
Yeah, I think we can remove the ignores. I just wanted to point out that the tests don't actually run, because from the PR description it seemed to me like you thought they do. |
I definitely did. I should probably check all the other targets. |
1766d85
to
c6815c0
Compare
@bors r+ rollup |
…r=compiler-errors Re-enable more debuginfo tests on freebsd These ignores are _ancient_, we don't run freebsd tests in CI, and even if we did they'd probably pass because the test suite passes with the latest gdb release on Linux.
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#128598 (float to/from bits and classify: update for float semantics RFC) - rust-lang#128990 (Re-enable more debuginfo tests on freebsd) - rust-lang#129042 (Special-case alias ty during the delayed bug emission in `try_from_lit`) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#128990 (Re-enable more debuginfo tests on freebsd) - rust-lang#129042 (Special-case alias ty during the delayed bug emission in `try_from_lit`) - rust-lang#129086 (Stabilize `is_none_or`) - rust-lang#129149 (Migrate `validate_json.py` script to rust in `run-make/rustdoc-map-file` test) - rust-lang#129154 (Fix wrong source location for some incorrect macro definitions) - rust-lang#129161 (Stabilize std::thread::Builder::spawn_unchecked) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128990 - saethlin:freebsd-debuginfo-tests, r=compiler-errors Re-enable more debuginfo tests on freebsd These ignores are _ancient_, we don't run freebsd tests in CI, and even if we did they'd probably pass because the test suite passes with the latest gdb release on Linux.
Bors is not correctly removing items from the queue @bors r- |
These ignores are ancient, we don't run freebsd tests in CI, and even if we did they'd probably pass because the test suite passes with the latest gdb release on Linux.