std: Rename {push,read}_bytes to {push,read}_exact #12907
Merged
+21
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I don't know if this should wait on a weekly meeting or something. |
These methods can be mistaken for general "read some bytes" utilities when they're actually only meant for reading an exact number of bytes. By renaming them it's much clearer about what they're doing without having to read the documentation. Closes rust-lang#12892
bors
added a commit
that referenced
this pull request
Mar 22, 2014
These methods can be mistaken for general "read some bytes" utilities when they're actually only meant for reading an exact number of bytes. By renaming them it's much clearer about what they're doing without having to read the documentation. Closes #12892
Kroisse
added a commit
to Kroisse/rust-http
that referenced
this pull request
Mar 22, 2014
related issues of mozilla/rust: - rust-lang/rust#12772 rename std::vec -> std::slice - rust-lang/rust#13028 rename std::vec_ng -> std::vec - rust-lang/rust@0305ed5d22e4 std: Add Vec to the prelude - rust-lang/rust#12907 std: Rename {push,read}_bytes to {push,read}_exact
Kroisse
added a commit
to Kroisse/rust-http
that referenced
this pull request
Mar 22, 2014
related issues of mozilla/rust: - rust-lang/rust#12772 rename std::vec -> std::slice - rust-lang/rust#13028 rename std::vec_ng -> std::vec - rust-lang/rust@0305ed5d22e4 std: Add Vec to the prelude - rust-lang/rust#12907 std: Rename {push,read}_bytes to {push,read}_exact
Kroisse
added a commit
to Kroisse/rust-http
that referenced
this pull request
Mar 30, 2014
related issues of mozilla/rust: - rust-lang/rust@0305ed5d22e4 std: Add Vec to the prelude already fixed in chris-morgan#69: - rust-lang/rust#12772 rename std::vec -> std::slice - rust-lang/rust#13028 rename std::vec_ng -> std::vec - rust-lang/rust#12907 std: Rename {push,read}_bytes to {push,read}_exact
am0d
pushed a commit
to am0d/rust-http
that referenced
this pull request
Apr 4, 2014
related issues of mozilla/rust: - rust-lang/rust@0305ed5d22e4 std: Add Vec to the prelude already fixed in chris-morgan#69: - rust-lang/rust#12772 rename std::vec -> std::slice - rust-lang/rust#13028 rename std::vec_ng -> std::vec - rust-lang/rust#12907 std: Rename {push,read}_bytes to {push,read}_exact
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
…ws a value Fixes rust-lang#12907 changelog: Fix [`needless_return`] false negative when returned expression borrows a value
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
Fix [`needless_return`] false negative Fixes rust-lang#12907 changelog: Fix [`needless_return`] false negative when returned expression borrows a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods can be mistaken for general "read some bytes" utilities when
they're actually only meant for reading an exact number of bytes. By renaming
them it's much clearer about what they're doing without having to read the
documentation.
Closes #12892