-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for #129541 #129542
Add regression test for #129541 #129542
Conversation
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
I'm putting my review on hold because I'm unsure about the implications of this. This is a concrete example of something that went legal after #122493 landed, when the PR itself did not anticipate allowing more code to compile ("This should not make more or less code compile"). The code snippet here looks fine and sound to me; but I'm not sure if there would be some cursed code that would be unsound and then allowed by the PR. cc @lukas-code @rust-lang/types |
r=me when the fcp is done in the linked issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the test from #129541 (comment) (or a minimized version):
#[derive(Clone)]
struct Hello {
a: <[Hello] as ToOwned>::Owned,
}
so that we actually test that this is allowed because Sized
is coinductive and not just because we skip the Sized
check for enums now.
e55fc73
to
5f72f9d
Compare
@bors r+ rollup |
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#129542 (Add regression test for rust-lang#129541) - rust-lang#129755 (test: cross-edition metavar fragment specifiers) - rust-lang#130566 (Break up compiletest `runtest.rs` into smaller helper modules) - rust-lang#130585 (Add tidy check for rustdoc templates to ensure the whitespace characters are all stripped) - rust-lang#130605 (Fix feature name in test) - rust-lang#130607 ([Clippy] Remove final std paths for diagnostic item) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#129542 - zachs18:cow-self-test, r=compiler-errors Add regression test for rust-lang#129541 (maybe?) closes rust-lang#129541 by adding a test that the code in question continues to compile.
(maybe?) closes #129541 by adding a test that the code in question continues to compile.