Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial fs implementation for UEFI #129700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initial fs implementation for UEFI #129700

wants to merge 1 commit into from
+1,083 −14

Conversation

Ayush1325
Copy link
Contributor

@Ayush1325 Ayush1325 commented Aug 28, 2024 •
edited
Loading

  • Only implementing basic file stuff for now.
  • Not implementing path::absolute right now since absolute UEFI paths
    will not be recognized as absolute path anyway.
  • Supports both UEFI shell mapping and device path text representation.
  • Follows closely UEFI shell file implementations.

Avoiding directory stuff for now. Also only works for absolute paths.
r? @joboet

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 28, 2024
@bors
Copy link
Contributor

bors commented Sep 23, 2024

☔ The latest upstream changes (presumably #130755) made this pull request unmergeable. Please resolve the merge conflicts.

@Ayush1325 Ayush1325 marked this pull request as draft October 19, 2024 15:31
@joboet
Copy link
Member

joboet commented Oct 28, 2024

As this is still a draft, I'm assuming you still want to work on it a bit (I'm cleaning up my review queue)?
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@Ayush1325 Ayush1325 force-pushed the uefi-file branch 2 times, most recently from 4f422c1 to ebbe0e4 Compare October 29, 2024 05:47
@Ayush1325 Ayush1325 marked this pull request as ready for review October 29, 2024 05:48
@Ayush1325
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 29, 2024
@Ayush1325 Ayush1325 mentioned this pull request Nov 5, 2024
Open
@Ayush1325
Initial fs implementation for UEFI
c60d97e 
- Only implementing basic file stuff for now.
- Not implementing path::absolute right now since absolute UEFI paths
  will not be recognized as absolute path anyway.
- Supports both UEFI shell mapping and device path text representation.
- Follows closely UEFI shell file implementations.

Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joboet joboet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ayush1325 @bors @joboet @rustbot