Skip to content

Add unreachable_pub, round 3 #129732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 29, 2024
Merged

Add unreachable_pub, round 3 #129732

merged 15 commits into from
Aug 29, 2024

Conversation

@nnethercote
Copy link
Contributor

A follow-up to #129648.

r? @Urgau

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2024

Some changes occurred in exhaustiveness checking

cc @Nadrieril

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau
Copy link
Member

Urgau commented Aug 29, 2024 •
edited
Loading

r=me after fixing the new entry in rustc_passes/src/errors.rs

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2024
@nnethercote
Add warn(unreachable_pub) to rustc_macros.
4b92682
@nnethercote
Add warn(unreachable_pub) to rustc_metadata.
05e0738
@nnethercote
Add warn(unreachable_pub) to rustc_middle.
938daf6 
I am surprised the diff is so small for this enormous crate.
@nnethercote
Add warn(unreachable_pub) to rustc_mir_build.
c16e289
@nnethercote
Add warn(unreachable_pub) to rustc_mir_dataflow.
8a8dd3f
@nnethercote
Add warn(unreachable_pub) to rustc_monomorphize.
e306214
@nnethercote
Add warn(unreachable_pub) to rustc_next_trait_solver.
46ea798
@nnethercote
Add warn(unreachable_pub) to rustc_parser.
cac04a1
@nnethercote
Add warn(unreachable_pub) to rustc_parse_format.
76bd802
@nnethercote
Add warn(unreachable_pub) to rustc_passes.
f778212
@nnethercote
Add warn(unreachable_pub) to rustc_pattern_analysis.
653ee7b
@nnethercote
Add warn(unreachable_pub) to rustc_privacy.
71bffef
@nnethercote
Add warn(unreachable_pub) to rustc_query_impl.
2eea2d2
@nnethercote
Add warn(unreachable_pub) to rustc_query_system.
afc58be
@nnethercote
Add warn(unreachable_pub) to rustc_resolve.
7a71a91
@nnethercote
Copy link
Contributor Author

@bors r=Urgau rollup

@bors
Copy link
Collaborator

bors commented Aug 29, 2024

📌 Commit 7a71a91 has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 29, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 29, 2024
@bors
Auto merge of rust-lang#129750 - GuillaumeGomez:rollup-gphsb7y, r=Gui…
cff318c 
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123940 (debug-fmt-detail option)
 - rust-lang#128166 (Improved `checked_isqrt` and `isqrt` methods)
 - rust-lang#128970 (Add `-Zlint-llvm-ir`)
 - rust-lang#129316 (riscv64imac: allow shadow call stack sanitizer)
 - rust-lang#129690 (Add `needs-unwind` compiletest directive to `libtest-thread-limit` and replace some `Path` with `path` in `run-make`)
 - rust-lang#129732 (Add `unreachable_pub`, round 3)
 - rust-lang#129743 (Fix rustdoc clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 29, 2024
@bors
Auto merge of rust-lang#129750 - GuillaumeGomez:rollup-gphsb7y, r=Gui…
0d63418 
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123940 (debug-fmt-detail option)
 - rust-lang#128166 (Improved `checked_isqrt` and `isqrt` methods)
 - rust-lang#128970 (Add `-Zlint-llvm-ir`)
 - rust-lang#129316 (riscv64imac: allow shadow call stack sanitizer)
 - rust-lang#129690 (Add `needs-unwind` compiletest directive to `libtest-thread-limit` and replace some `Path` with `path` in `run-make`)
 - rust-lang#129732 (Add `unreachable_pub`, round 3)
 - rust-lang#129743 (Fix rustdoc clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7e23a44 into rust-lang:master Aug 29, 2024
@rustbot rustbot added this to the 1.82.0 milestone Aug 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 29, 2024
@rust-timer
Unrolled build for rust-lang#129732
6c40c7f 
Rollup merge of rust-lang#129732 - nnethercote:unreachable_pub-3, r=Urgau

Add `unreachable_pub`, round 3

A follow-up to rust-lang#129648.

r? `@Urgau`
@nnethercote nnethercote deleted the unreachable_pub-3 branch August 29, 2024 23:47
@nnethercote nnethercote mentioned this pull request Aug 30, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Aug 31, 2024
@workingjubilee
Rollup merge of rust-lang#129777 - nnethercote:unreachable_pub-4, r=U…
9292173 
…rgau

Add `unreachable_pub`, round 4

A follow-up to rust-lang#129732.

r? `@Urgau`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#129777 - nnethercote:unreachable_pub-4, r=U…
66366f5 
…rgau

Add `unreachable_pub`, round 4

A follow-up to rust-lang#129732.

r? ````@Urgau````
@lcnr lcnr removed the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Sep 2, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2024
@bors
Auto merge of rust-lang#129777 - nnethercote:unreachable_pub-4, r=Urgau
6199b69 
Add `unreachable_pub`, round 4

A follow-up to rust-lang#129732.

r? `@Urgau`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote @rustbot @rust-log-analyzer @Urgau @bors @lcnr