Prereq4 for async drop - needs_async_drop query fixes and some cleanup #129739
Conversation
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras This PR changes Stable MIR |
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
b667246 to
ccf830a
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
ccf830a to
b193d6a
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #129817) made this pull request unmergeable. Please resolve the merge conflicts. |
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
2 times, most recently
from
e0d8585 to
aa7c159
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
aa7c159 to
2d5cad6
Compare
|
☔ The latest upstream changes (presumably #129313) made this pull request unmergeable. Please resolve the merge conflicts. |
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
2d5cad6 to
81c51d9
Compare
|
☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @nikomatsakis is going to look into this |
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
81c51d9 to
2b693c0
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #136751) made this pull request unmergeable. Please resolve the merge conflicts. |
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
2 times, most recently
from
fca16b3 to
4efe2f2
Compare
|
☔ The latest upstream changes (presumably #136943) made this pull request unmergeable. Please resolve the merge conflicts. |
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
4efe2f2 to
0da1dc0
Compare
|
☔ The latest upstream changes (presumably #139354) made this pull request unmergeable. Please resolve the merge conflicts. |
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
0da1dc0 to
85f10ba
Compare
…p from previous async drop glue implementation
azhogin
force-pushed
the
azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
branch
from
85f10ba to
b1f3a6e
Compare
|
☔ The latest upstream changes (presumably #139578) made this pull request unmergeable. Please resolve the merge conflicts. |
8 participants
This is subpart 4 PR of #123948, just for review purposes.
is_async_dropquery added, smallneeds_async_dropfixes and previous async drop glue implementation cleanup.is_async_dropfor detection of type implementing AsyncDrop trait itself,needs_async_dropfor detection if a complex type have some internals implementing AsyncDrop and requires async drop glue for itself.Review only last commit, based on previous PR #129737.