-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Subpart7 for async drop (major1) - library changes #129742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subpart7 for async drop (major1) - library changes #129742
Conversation
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 This PR changes Stable MIR cc @oli-obk, @celinval, @ouz-a This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
/// Allows implementing `AsyncDrop`. | ||
(incomplete, async_drop, "CURRENT_RUSTC_VERSION", Some(126482)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see feature gates in the compiler being tested. If this all hinges on the library feature gate, then let it hinge on the library feature gate, and remove the compiler gate.
/// Allows implementing `AsyncDrop`. | |
(incomplete, async_drop, "CURRENT_RUSTC_VERSION", Some(126482)), |
2199d76
to
cc9bedd
Compare
bdbfcd7
to
f2fdd69
Compare
☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
r? @nikomatsakis is going to look into this |
48e915e
to
f27e316
Compare
…p from previous async drop glue implementation
f27e316
to
44e7087
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #139578) made this pull request unmergeable. Please resolve the merge conflicts. |
This is subpart 7 PR of #123948, just for review purposes.
Library changes:
async fn async_drop_in_place<T>(dropee)
declaration etc.Review only last commit, based on previous PR #129741