- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
[stable] Fix CVE-2024-43402 #129960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            [stable] Fix CVE-2024-43402 #129960
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           @bors r+ p=1000 rollup=never  | 
    
| 
           Good luck with the CI gods, friend 🤞  | 
    
| 
           ☀️ Test successful - checks-actions  | 
    
    
  bors-ferrocene bot
      added a commit
        to ferrocene/ferrocene
      that referenced
      this pull request
    
      Jan 24, 2025 
    
    
      
  
    
      
    
  
1245: [1.83] Backport KP docs, release notes fix r=pietroalbini a=Hoverbear Backports * #1244 Also backports rust-lang/rust@24906b5 which which upstream is also doing: rust-lang/rust#135934 In the case of 24906b5, this is somewhat of a special circumstance. We noticed during our own release process that our 1.81 (so 24.11) release notes had changed and this change (along with rust-lang/rust#126967 which was removed with rust-lang/rust#129995) had disappeared. We confirmed the fix for rust-lang/rust#129960 is indeed in tree, but upstream never ported the release note update to their main branch. This port is being done in rust-lang/rust#135934. Co-authored-by: Pietro Albini <pietro.albini@ferrous-systems.com>
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Jan 25, 2025 
    
    
      
  
    
      
    
  
…-Simulacrum Include missing item in the 1.81 release notes It was pointed out to me that when I prepared the CVE-2024-43402 fix in the stable branch, I added the release notes in the stable PR (rust-lang#129960), but I forgot to do so in the beta or nightly PR. Because of that, the relnotes line only appeared in 1.81, and disappeared afterwards.
    
  rust-timer 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Jan 26, 2025 
    
    
      
  
    
      
    
  
Rollup merge of rust-lang#135934 - ferrocene:pa-1.81-relnotes, r=Mark-Simulacrum Include missing item in the 1.81 release notes It was pointed out to me that when I prepared the CVE-2024-43402 fix in the stable branch, I added the release notes in the stable PR (rust-lang#129960), but I forgot to do so in the beta or nightly PR. Because of that, the relnotes line only appeared in 1.81, and disappeared afterwards.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    merged-by-bors
  This PR was explicitly merged by bors. 
  
    O-windows
  Operating system: Windows 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  
    T-libs
  Relevant to the library team, which will review and decide on the PR/issue. 
  
    T-release
  Relevant to the release subteam, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Backport the fix for CVE-2024-43402 in the upcoming 1.81.0. See GHSA-2xg3-7mm6-98jj for more information about it.
This also includes #129944 as a last-minute fix to the relnotes.
cc @BoxyUwU as you are driving this release
r? @ghost